| commit | 2757713637fa18ca70ff9dbc55bf8c54c9d46a2c | |
| author | Iain Patterson <wm@iain.cx> | |
| Thu, 24 Oct 2013 10:59:30 +0000 (24 11:59 +0100) | ||
| committer | Carlos R. Mafra <crmafra@gmail.com> | |
| Thu, 24 Oct 2013 13:52:39 +0000 (24 11:52 -0200) | ||
| tree | 3a26a5c04099d6df10e13e5e70f5e68e4669d59d | treesnapshot (tar.gz zip) |
| parent | e650bf49ea6012bce95c6b17b1956ad57c77da5d | commitdiff |
Avoid unnecessary wWindowConfigure().
If a window handles a ConfigureRequest which did not specify a move or
resize operation we should not call wWindowConfigure() and save the
window geometry.
Sergey Popov reported a scenario in which the old behaviour caused a bug:
* Start gvim with a server.
"gvim --servername qwe .gimvrc"
* Maximize gvim.
* (Re)open a file in the same window
"gvim --servername qwe --remote-silent .gvimrc"
* Now the window claims to be unmaximized and its old geometry is
forgotten.
The bug was that when the gvim window reread the file it generated a
ConfigureRequest without specifying a geometry change but we called
wWindowConfigure() and saved its geometry as though it had been
maximized.
If a window handles a ConfigureRequest which did not specify a move or
resize operation we should not call wWindowConfigure() and save the
window geometry.
Sergey Popov reported a scenario in which the old behaviour caused a bug:
* Start gvim with a server.
"gvim --servername qwe .gimvrc"
* Maximize gvim.
* (Re)open a file in the same window
"gvim --servername qwe --remote-silent .gvimrc"
* Now the window claims to be unmaximized and its old geometry is
forgotten.
The bug was that when the gvim window reread the file it generated a
ConfigureRequest without specifying a geometry change but we called
wWindowConfigure() and saved its geometry as though it had been
maximized.
| src/client.c | diffblobblamehistory |