| commit | 335e96e5816ea43cf93a737d499f1021bbad1cf3 | |
| author | Stefan Becker <stefan.becker@nokia.com> | |
| Wed, 20 Oct 2010 19:21:39 +0000 (20 22:21 +0300) | ||
| committer | Anibal Avelar <aavelar@cofradia.org> | |
| Wed, 3 Nov 2010 03:51:23 +0000 (2 21:51 -0600) | ||
| tree | d12c7c3cec2f803b4beca3b0925f07b085d92a18 | treesnapshot (tar.gz zip) |
| parent | f199c773a316c04d37dfa473ec284296b0f1a688 | commitdiff |
Fix #3090663: Re-authentication fails (2nd attempt)
Commit f41ea03faed867cb7261b1a7f99a2367d2075919 had the right idea but there
were two problems with it:
- wrong authentication data, e.g. wrong password, was no longer detected and
caused an endless re-authentication loop.
- the pending transaction of the rejected REGISTER message was not removed,
causing dangling transactions to pile up over time.
While trying to figure out how to handle the first problem correctly, I noticed
that the information in transport->register_status was useless. I removed the
field and all references to it from the code.
I also cleaned up some of the debug messages in sip-transport.c.
(cherry picked from commit 2580b6f0e838df159e9aa1ca1c9e4c62dab69c6c)
Commit f41ea03faed867cb7261b1a7f99a2367d2075919 had the right idea but there
were two problems with it:
- wrong authentication data, e.g. wrong password, was no longer detected and
caused an endless re-authentication loop.
- the pending transaction of the rejected REGISTER message was not removed,
causing dangling transactions to pile up over time.
While trying to figure out how to handle the first problem correctly, I noticed
that the information in transport->register_status was useless. I removed the
field and all references to it from the code.
I also cleaned up some of the debug messages in sip-transport.c.
(cherry picked from commit 2580b6f0e838df159e9aa1ca1c9e4c62dab69c6c)
| src/core/sip-transport.c | diffblobblamehistory |