| commit | 531106e51e519458d37bed3721da4eff2f163206 | |
| author | Eric Wong <normalperson@yhbt.net> | |
| Fri, 8 Jan 2010 19:30:49 +0000 (8 11:30 -0800) | ||
| committer | Eric Wong <normalperson@yhbt.net> | |
| Fri, 8 Jan 2010 19:30:49 +0000 (8 11:30 -0800) | ||
| tree | 099b2b225dd646c0b8bfb24175fef7773e924a30 | treesnapshot (tar.gz zip) |
| parent | d03c76ae11ca6294e05262df747e4d43822ada73 | commitdiff |
no point in non-blocking for fd notifications
It's not needed since the native thread will retry in the
unlikely case of EINTR/EAGAIN. And writing one byte to a pipe
that's guaranteed by POSIX to be at least 512 bytes is highly
unlikely.
It's also bad because F_SETFL takes the big kernel lock under
Linux (and possibly other systems), and doing it unnecessarily
is a waste of system cycles.
It's not needed since the native thread will retry in the
unlikely case of EINTR/EAGAIN. And writing one byte to a pipe
that's guaranteed by POSIX to be at least 512 bytes is highly
unlikely.
It's also bad because F_SETFL takes the big kernel lock under
Linux (and possibly other systems), and doing it unnecessarily
is a waste of system cycles.
| ext/posix_mq/posix_mq.c | diffblobblamehistory |