| commit | 81a322d4a1b68d47908a6630bf22897a289722aa | |
| author | Gerd Hoffmann <kraxel@redhat.com> | |
| Fri, 14 Aug 2009 08:36:05 +0000 (14 10:36 +0200) | ||
| committer | Anthony Liguori <aliguori@us.ibm.com> | |
| Fri, 28 Aug 2009 01:43:28 +0000 (27 20:43 -0500) | ||
| tree | cdca9840d0620d9e0b46d7b81c58abe04a372b78 | treesnapshot (tar.gz zip) |
| parent | 24e6f3551f3c8ea7cc7524a3e64e84beca59618f | commitdiff |
qdev: add return value to init() callbacks.
Sorry folks, but it has to be. One more of these invasive qdev patches.
We have a serious design bug in the qdev interface: device init
callbacks can't signal failure because the init() callback has no
return value. This patch fixes it.
We have already one case in-tree where this is needed:
Try -device virtio-blk-pci (without drive= specified) and watch qemu
segfault. This patch fixes it.
With usb+scsi being converted to qdev we'll get more devices where the
init callback can fail for various reasons.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Sorry folks, but it has to be. One more of these invasive qdev patches.
We have a serious design bug in the qdev interface: device init
callbacks can't signal failure because the init() callback has no
return value. This patch fixes it.
We have already one case in-tree where this is needed:
Try -device virtio-blk-pci (without drive= specified) and watch qemu
segfault. This patch fixes it.
With usb+scsi being converted to qdev we'll get more devices where the
init callback can fail for various reasons.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
102 files changed: