From: Eric Wong Date: Sat, 3 Apr 2010 05:59:54 +0000 (-0700) Subject: mincore: mmap() returns MAP_FAILED on failure X-Git-Tag: v0.3.0~6 X-Git-Url: https://repo.or.cz/w/pcu.git/commitdiff_plain/d791dcdbc49667257af79ca9329ba83d1b934b88 mincore: mmap() returns MAP_FAILED on failure mmap() may return NULL on success in certain situations not applicable to us. The proper failure value is MAP_FAILED. --- diff --git a/mincore.c b/mincore.c index 3314d3c..4bdbd0c 100644 --- a/mincore.c +++ b/mincore.c @@ -45,7 +45,7 @@ static void mincore_stats(const char *path, off_t offset, off_t len) map_offset = PAGE_ALIGN_DOWN(offset + 1); map = mmap(NULL, map_len, PROT_READ, MAP_SHARED, fd, map_offset); - if (!map) { + if (map == MAP_FAILED) { fprintf(stderr, "%s: mmap(%lu): %s\n", path, (unsigned long)vec_len, strerror(errno)); goto err_free;