Update HACKING info47/747/4
authorFreddie Chopin <freddie.chopin@gmail.com>
Tue, 17 Jul 2012 07:49:37 +0000 (17 09:49 +0200)
committerØyvind Harboe <oyvindharboe@gmail.com>
Thu, 28 Feb 2013 06:22:51 +0000 (28 06:22 +0000)
Inform about possibility of discarding negative review in Gerrit when specific conditions are met.

Change-Id: I432b6c93cefc368fa22ce1096bea4cd174e03816
Signed-off-by: Freddie Chopin <freddie.chopin@gmail.com>
Reviewed-on: http://openocd.zylin.com/747
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
Tested-by: Øyvind Harboe <oyvindharboe@gmail.com>
HACKING

diff --git a/HACKING b/HACKING
index 2bd3114..d4f7a79 100644 (file)
--- a/HACKING
+++ b/HACKING
@@ -152,6 +152,13 @@ master branch will be much reduced.
 If a contributor pushes a patch, it is considered good form if another
 contributor actually approves and submits that patch.
 
+It should be noted that a negative review in Gerrit ("-1" or "-2") may (but does
+not have to) be disregarded if all conditions listed below are met:
+
+- the concerns raised in the review have been addressed (or explained),
+- reviewer does not re-examine the change in a month,
+- reviewer does not answer e-mails for another month.
+
 @section browsing Browsing Patches
 All OpenOCD patches can be reviewed <a href="http://openocd.zylin.com/">here</a>.
 */