| commit | 355f4cadbbf10c75cf05fb1a82bf918b3ab65c55 | |
| author | Paul Fertser <fercerpav@gmail.com> | |
| Sat, 17 Jan 2015 12:15:11 +0000 (17 15:15 +0300) | ||
| committer | Paul Fertser <fercerpav@gmail.com> | |
| Fri, 30 Jan 2015 08:56:54 +0000 (30 08:56 +0000) | ||
| tree | f874ce4af77346c82220be72f217b2b311cff380 | treesnapshot (tar.gz zip) |
| parent | 9d745a0690f6f5c24d914ebfa3c1d6b824a19a5e | commitdiff |
Use (uint8_t *) for buf_(set|get)_u(32|64) instead of (void *)
This helps to uncover incorrect usage when a pointer to uint32_t is
passed to those functions which leads to subtle bugs on BE systems.
The reason is that it's normally assumed that any uint32_t variable
holds its value in host byte order, but using but_set_u32 on it
silently does implicit pointer conversion to (void *) and the
assumption ends up broken without any indication.
Change-Id: I48ffd190583d8aa32ec1fef8f1cdc0b4184e4546
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Reviewed-on: http://openocd.zylin.com/2467
Tested-by: jenkins
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
This helps to uncover incorrect usage when a pointer to uint32_t is
passed to those functions which leads to subtle bugs on BE systems.
The reason is that it's normally assumed that any uint32_t variable
holds its value in host byte order, but using but_set_u32 on it
silently does implicit pointer conversion to (void *) and the
assumption ends up broken without any indication.
Change-Id: I48ffd190583d8aa32ec1fef8f1cdc0b4184e4546
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Reviewed-on: http://openocd.zylin.com/2467
Tested-by: jenkins
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>