Martin Langhoff [Thu, 20 Sep 2007 23:30:41 +0000 (21 11:30 +1200)]
auth/ldap: NTLM SSO - fix hardcoded strings
From Iñaki Arenaza
And here is a little patch with the last remaining non-traslated
strings (unless I missed something).
Martin Langhoff [Thu, 20 Sep 2007 23:29:13 +0000 (21 11:29 +1200)]
auth/ldap: NTLM SSO - move textlib conversion earlier
From Iñaki Arenaza - fix for
... I forgot to put the textlib conversion
call before the block of code that uses $extusername, so it
completely breaks the user validation process.
Martin Langhoff [Thu, 20 Sep 2007 23:26:07 +0000 (21 11:26 +1200)]
auth/ldap: NTLM SSO - cleanup of sesskey handling
Fix a bug in ntlmsso_finish(), and tighten up user_login() to avoid a
pointless DB lookup if the password doesn't match the sesskey.
Hopefully this makes things work again...
(thanks I~naki for the testing!)
Martin Langhoff [Thu, 20 Sep 2007 06:17:29 +0000 (20 18:17 +1200)]
auth/ldap: Add a cron() handler, and use it to clean stale NTLM sessions
Clear up the stale NTLM sessions, extracting the timestamp via SUBSTR()
and using a string comparison. Ugly, but actually more portable than
trying to CAST(). At least until 2038!
Martin Langhoff [Thu, 20 Sep 2007 05:40:14 +0000 (20 17:40 +1200)]
auth/ldap: NTLM SSO - use sesskey and other tidyups
Several tidyups:
- use moodle_strtolower() for utf-8 correctness
- use sesskey as the key instead of IP addr to support
proxied users
- clean the sesskey after success!
- pull timeout out to a constant: AUTH_NTLMTIMEOUT
Martin Langhoff [Thu, 20 Sep 2007 05:20:28 +0000 (20 17:20 +1200)]
moodlelib: set_config() deletes config entries if the value is NULL
New! Improved! If you pass NULL as the value, it will delete the
config entry for you.
Martin Langhoff [Thu, 20 Sep 2007 03:54:55 +0000 (20 15:54 +1200)]
auth/ldap: Tighten NTLM AD checks to the appropriate OU
From Iñaki Arenaza...
Right now, if someone logs in via NTLM magic, we don't check if that
user is inside the contexts specified in the LDAP settings. I mean,
if I want to restrict my Moodle site to those users inside a given OU
or subtree of my LDAP directory, with the current code any valid user
in my whole AD domain (and if we are using a GC as the LDAP server,
the whole forest) can log in. We should check that the user is inside
one of the configured contexts before allowing his/her to log in.
Something along the lines of the attached patch could do it.
Martin Langhoff [Tue, 18 Sep 2007 23:22:11 +0000 (19 11:22 +1200)]
auth/ldap: ntlmsso_finish() now completes the user session setup
As Iñaki points out, ntlmsso_finish() needs to do all the setup that
login/index.php would do for a user once auth succeeds. With this
patch, the session setup is complete so the logon is usable.
Martin Langhoff [Tue, 18 Sep 2007 23:11:02 +0000 (19 11:11 +1200)]
login/index, moodlelib: move session setup logic to complete_user_login()
Move most of the user session setup logic from login/index.php to
complete_user_login().
Martin Langhoff [Tue, 18 Sep 2007 22:48:14 +0000 (19 10:48 +1200)]
auth/ldap: NTLM redirect only on initial GET
We only want to redirect when users are being shown the login page (on
GET) but not when users are POSTing to it, actually trying to login.
Martin Langhoff [Tue, 18 Sep 2007 22:39:35 +0000 (19 10:39 +1200)]
auth/ldap: NTLM SSO - lots of fixes from Iñaki
Lots of typos and minor errors fixed by Iñaki. Thanks!
Martin Langhoff [Tue, 18 Sep 2007 01:35:38 +0000 (18 13:35 +1200)]
auth/ldap: NTLM SSO - Resolve Moodle cookies issue, tighten config.php require()s
Use $nomoodlecookie global to avoid session troubles. Also
* Ensure we load the appropriate config.php, even if we are executing
under a strange environment (ie: with a user's credentials!)
* Test we have a spacer gif to open before we open it
Martin Langhoff [Tue, 18 Sep 2007 00:39:36 +0000 (18 12:39 +1200)]
auth/ldap: Add NTLM SSO pages
These pages control the process of attempting an NTLM SSO login
safely. This is very draft and needs real-world testing and polish.
And string localisation too ;-)
* If NTLM SSO is enabled, and the user's IP addr is in the right
subnet, the loginpage_hook() of auth/ldap redirects to
ntlmsso_attempt.php
* ntlmsso_attempt.php will display a "redirect" msg with an img tag
pointing to ntlmsso_magic.php, a 3s wait, and a redirect to
ntlmsso_finish.php
* ntlmsso_magic.php should be configured to have "Integrated
Windows Authentication". If it does, it will serve a spacer gif
and call ntlmsso_magic()
* ntlmsso_finish.php calls ntlmsso_finish() to complete the SSO
and handles failures.
Martin Langhoff [Tue, 18 Sep 2007 00:31:28 +0000 (18 12:31 +1200)]
auth/ldap: flesh out ntlmsso_* functions
Flesh out the functions that get the job done. These will be triggered
by PHP files sitting under auth/ldap/ ...
ntlmsso_magic() - here is where the magic happens. Call it serving
something harmless, like a space GIF, from a URL that is blessed with
Integrated Windows Authentication. If the IWA is successful, it will
set a special session cookie in config_plugins table.
It won't complete the job because when we are under IWA magic we
cannot change (even read!) the session data, as the execution happens
under the OS privileges of the actual user acct being logged in (!!!)
ntlmsso_finish() - if it finds the session set by ntlmsso_magic() and
it hasn't expired, it will finish the job of logging in the user, by
calling authenticate_user_login() and exercising the whole auth
machinery.
user_login() - when called by authenticate_user_login() it will check
to see if there's a session setup by ntlmsso_magic() and OK the login
without really asking the AD backend to proof a password we don't have
anyway.
Martin Langhoff [Mon, 17 Sep 2007 05:52:51 +0000 (17 17:52 +1200)]
auth/ldap: Introducing loginpage_hook(), ntlmsso_attempt(), ntlmsso_finish()
A work in progress -- initial loginpage_hook() and headers for the
remaining functions. One thing to consider here is that this won't
work if there's a proxy in the middle.
Does NTLM auth thingy support proxies?
Martin Langhoff [Mon, 17 Sep 2007 05:20:08 +0000 (17 17:20 +1200)]
auth/ldap: Manage 2 new config settings for NTLM SSO
Changes in the forms and forms handling to set and edit NTLM SSO
related config options.
moodler [Sun, 16 Sep 2007 04:12:52 +0000 (16 04:12 +0000)]
installer.php lang files by installer_builder (
20070916)
iarenaza [Sat, 15 Sep 2007 21:38:13 +0000 (15 21:38 +0000)]
Remove additional check when dealing with hidden courses in LDAP enrolment.
The check is superfluous and uses an inexistant variable ($type) that
was removed when we switched to role based enrolment.
Fixes MDL-11098 MDL-10282 and MDL-8346.
skodak [Sat, 15 Sep 2007 21:17:11 +0000 (15 21:17 +0000)]
MDL-11296 fixed incorrect detection of duplicate scales in course
skodak [Sat, 15 Sep 2007 19:43:01 +0000 (15 19:43 +0000)]
applying the same patch to advcheckbox - Fixes MDL-8627, "HTML QuickForm displays (some?) disabled elements in a non-accessible way", overrides parent::getFrozenHtml.
skodak [Sat, 15 Sep 2007 19:36:31 +0000 (15 19:36 +0000)]
MDL-11295 editorshortcutshelpbutton breaking xhtml strict
skodak [Sat, 15 Sep 2007 19:24:10 +0000 (15 19:24 +0000)]
MDL-9542 new function needed for showing of final grades in Quiz + minor changes in grading public API used by modules
skodak [Sat, 15 Sep 2007 13:23:28 +0000 (15 13:23 +0000)]
fixed wrong $options - this->keepdrop_options used instead
skodak [Sat, 15 Sep 2007 09:42:24 +0000 (15 09:42 +0000)]
MDL-10277 Force password change cannot be unchecked once selected
skodak [Sat, 15 Sep 2007 09:29:58 +0000 (15 09:29 +0000)]
MDL-11292 fixed Cannot create child auth plugins - patch by Mark Nielsen; used inlude_once() when searching for functions/methods in files
nicolasconnault [Fri, 14 Sep 2007 19:32:50 +0000 (14 19:32 +0000)]
MDL-11282 Using notice_yesno(), but not sure how to provide a backlink with the cancel action...
nicolasconnault [Fri, 14 Sep 2007 17:21:30 +0000 (14 17:21 +0000)]
MDL-11278 Implementation is complete, but grade_categories records in DB are not affected by global settings. This way, when global settings are switched back to "Do not Force", the original category settings will be in place.
nicolasconnault [Fri, 14 Sep 2007 10:40:49 +0000 (14 10:40 +0000)]
MDL-11278 Admin settings page completed, implementation of settings in the gradebook coming up next.
tjhunt [Fri, 14 Sep 2007 09:42:53 +0000 (14 09:42 +0000)]
MDL-11271 - The closing bracket "}" can't be used in cloze question type. Now, you can excape a closing } with a backslash. Do feedback, as well as answer. Merged from MOODLE_18_STABLE.
tjhunt [Fri, 14 Sep 2007 09:34:52 +0000 (14 09:34 +0000)]
MDL-11271 - The closing bracket "}" can't be used in cloze question type. Now, you can excape a closing } with a backslash. Merged from MOODLE_18_STABLE.
tjhunt [Fri, 14 Sep 2007 09:33:30 +0000 (14 09:33 +0000)]
MDL-11284 - Can't save edited questions
nicolasconnault [Fri, 14 Sep 2007 08:54:46 +0000 (14 08:54 +0000)]
MDL-11278 Admin settings page completed, implementation of settings in the gradebook coming up next.
toyomoyo [Fri, 14 Sep 2007 08:43:10 +0000 (14 08:43 +0000)]
MDL-11274, hide grades in the grader report if the current grades has no viewhidden capability
nicolasconnault [Fri, 14 Sep 2007 06:57:30 +0000 (14 06:57 +0000)]
Issue:
The number of submissions in the Group average and Course average calculations
should be shown in brackets. (submissions) should be added after the Group average
and Course average labels.
Solution:
new grader report preference (Display number of grades in average cells).
moodler [Fri, 14 Sep 2007 06:51:57 +0000 (14 06:51 +0000)]
Fix the location of the link to the site-wide grading preferences
moodler [Fri, 14 Sep 2007 05:45:38 +0000 (14 05:45 +0000)]
Changing string for Overall average (was logged under MDL-11233 even though that's not strictly the correct bug)
stronk7 [Thu, 13 Sep 2007 17:51:48 +0000 (13 17:51 +0000)]
Now using one cross-db solution to be able to
simulate the status boolean ins assignment
submissions. MDL-8164 & MDL-10846
tjhunt [Thu, 13 Sep 2007 17:29:08 +0000 (13 17:29 +0000)]
MDL-11081 and MDL-11211 - Implement quiz_question_list_instances. The lach of this function was causing a horrible dataloss bug: MDL-11211. Fix thanks to Janne Mikkonen, refined by me. Merged from MOODLE_16_STABLE.
tjhunt [Thu, 13 Sep 2007 16:25:00 +0000 (13 16:25 +0000)]
MDL-11213 - Quiz preview attempts show up in item analysis. Fix thanks to Jean-Michel Vedrine. Merged from MOODLE_18_STABLE.
nicolasconnault [Thu, 13 Sep 2007 15:11:16 +0000 (13 15:11 +0000)]
Issue:
Only students should appear in the tutor report, however
sorting by Surname results in the tutor being included, which we don't want.
Solution:
Confirmed as a bug and filed in tracker: http://tracker.moodle.org/browse/MDL-11233
Issue:
Clicking on Hide Groups reveals the results for all students
and all tutors and course staff appear. A tutor should only be able to see
the results for their tutor group
Solution:
Prevent tutors from ever seeing student grades from other groups: use existing capabilities
moodle/site:accessallgroups = off AND moodle/grade:viewall = on
Issue:
Preferences tab should not be available to users without gradereport/grader:manage capability
Solution:
Hide the tab completely
Issue:
Apply different style to average cells
Solution:
Add css classes to the different average cells, and write a default style in css file.
Issue:
The Average under group average might be better labelled Course average.
Solution:
Rename to "Complete average"
nicolasconnault [Thu, 13 Sep 2007 13:44:35 +0000 (13 13:44 +0000)]
MDL-11233 Corrected typo in grader report lib, and added a second sort parameter for lastname and firstname sorts, to add consistency to result sets. Non-students no longer appear in the list
tjhunt [Thu, 13 Sep 2007 10:47:05 +0000 (13 10:47 +0000)]
MDL-11231 - Missing "correct" tick in Close question with answer '0'. Merged from MOODLE_18_STABLE.
nfreear [Thu, 13 Sep 2007 09:13:00 +0000 (13 09:13 +0000)]
MDL-11160, Cron exhausts memory on "Removing expired enrolments ..." - changing nested foreach to JOINs with while(..rs_fetch_next_record).
moodler [Thu, 13 Sep 2007 08:59:31 +0000 (13 08:59 +0000)]
Added Zoomspider as allowed to enter when opentogoogle is open
moodler [Thu, 13 Sep 2007 06:42:49 +0000 (13 06:42 +0000)]
Patch as suggested by Eloy in MDL-11237 to work around a nasty PHP bug in PHP 5.20
nicolasconnault [Thu, 13 Sep 2007 04:02:55 +0000 (13 04:02 +0000)]
MDL-11238 Removed reference to $grade_grade->feedback and replaced with grade_grade_text->feedback. Also instantiated the $grade_grade object properly instead of just get_record(), so that its set_hidden() method could be accessible.
diml [Wed, 12 Sep 2007 21:23:55 +0000 (12 21:23 +0000)]
changes reindexing strategy : deletes records rather than create back table
search db model transfered to block_search. No db model needed here.
diml [Wed, 12 Sep 2007 21:22:15 +0000 (12 21:22 +0000)]
changes reindexing strategy : deletes records rather than create back table
checkDB() and checkTableExists() in indexlib.php are obsolete
table name synced with search block install.xml table name
nicolasconnault [Wed, 12 Sep 2007 15:02:06 +0000 (12 15:02 +0000)]
Replacing the capability gradereport/grader:manage with moodle/grade:manage
nfreear [Wed, 12 Sep 2007 11:17:35 +0000 (12 11:17 +0000)]
Fixes MDL-8627, "HTML QuickForm displays (some?) disabled elements in a non-accessible way", overrides parent::getFrozenHtml.
sam_marshall [Wed, 12 Sep 2007 10:14:12 +0000 (12 10:14 +0000)]
MDL-11224 Updated UFO Flash JS library from 3.20 to 3.22, preserving minor Moodle-specific change (and added comment to top about it!)
donal72 [Wed, 12 Sep 2007 03:25:43 +0000 (12 03:25 +0000)]
Uninitialized variable
martinlanghoff [Wed, 12 Sep 2007 02:57:58 +0000 (12 02:57 +0000)]
admin/cron: if $PERF->dbqueries is set, profile modules...
The cron() function of some modules can be a huge drag on the
server. Capture profiling data...
martinlanghoff [Wed, 12 Sep 2007 02:57:26 +0000 (12 02:57 +0000)]
PERF logging - move handling to moodle_request_shutdown()
By moving the performance profile logging to the very
end of PHP processing, we cover more pages, notably those
that don't end up with a footer or a redirect, like file
serving.
This should improve quality of our performance logs, and
help catch some piggies...
martinlanghoff [Wed, 12 Sep 2007 02:57:08 +0000 (12 02:57 +0000)]
redirect() - log performance profiling info
Many heavy pages end in a redirect. Log their profiling data!
Thanks to Matt Clarkson for spotting the problem.
martinlanghoff [Wed, 12 Sep 2007 02:56:50 +0000 (12 02:56 +0000)]
admin/modules: Avoid calling rebuild_course_cache()
rebuild_course_cache() over all courses is extremely expensive,
not suitable for interactive calling. Better to clear modinfo
and let course/view.php repopulate it as needed.
With this patch we clear out modinfo _only_ for courses affected
by the module we show/hide/delete.
martinlanghoff [Wed, 12 Sep 2007 02:56:36 +0000 (12 02:56 +0000)]
course/index: move orphan fixups to an optimised fix_coursecategory_orphans()
Move the fixups for orphan courses to the newly minted
fix_coursecategory_orphans() -- and optimise it to take only 1 dbquery for
the common case.
If we do find lots of orphans, we issue 2 updates per orphan.
This cuts down dbqueries drastically - we used to have 2x the number of
courses in the site.
martinlanghoff [Wed, 12 Sep 2007 02:56:16 +0000 (12 02:56 +0000)]
fix_course_sortorder(): fix breakage with large categories, saner error
Two improvements for fix_course_sortorder()
- If the category has more courses than the shift range
use a larger shift range to avoid overlapping with itself
- If things do go wrong during the per-course sortorder updates,
rollback and try and call ourselves with a 'safe' flag.
Still - far from perfect. Probably the global sortorder approach
is broken. The sanest way is to rework things to always join against
course_categories and order by the combined sortorders.
stronk7 [Tue, 11 Sep 2007 19:39:28 +0000 (11 19:39 +0000)]
Annihilate one wrong use of getNameForObject() now
that we are able to detect REAL check constraints names
stronk7 [Tue, 11 Sep 2007 19:37:13 +0000 (11 19:37 +0000)]
And now, the unused getStandardNameForObject() is out. Back to the
exclusive getNameForObject() function, ONLY USED TO CREATE NEW
OBJECTS, NEVER TO GUESS THE NAME OF EXISTING ONES. MDL-9356
stronk7 [Tue, 11 Sep 2007 19:08:11 +0000 (11 19:08 +0000)]
Now we aren't guessing check constraint names
but getting the real ones under Oracle. MDL-9356
stronk7 [Tue, 11 Sep 2007 19:07:17 +0000 (11 19:07 +0000)]
Now we aren't guessing check constraint names
but getting the real ones under MSSQL. MDL-9356
stronk7 [Tue, 11 Sep 2007 19:06:38 +0000 (11 19:06 +0000)]
Now we aren't guessing check constraint names
but getting the real ones under PostgreSQL. MDL-9356
stronk7 [Tue, 11 Sep 2007 18:35:23 +0000 (11 18:35 +0000)]
Added some new test to check double creation
and deletion of enums (check constrainsts). MDL-9356
stronk7 [Tue, 11 Sep 2007 18:33:23 +0000 (11 18:33 +0000)]
General cleanup of debugging messages.
Now change_field_enum() introspects DB and detects
if the enum existed or no, as needed. MDL-9356
thepurpleblob [Tue, 11 Sep 2007 14:55:34 +0000 (11 14:55 +0000)]
Missing a stripslashes() so TeX functions didn't work
Merged from STABLE_18
thepurpleblob [Tue, 11 Sep 2007 13:55:33 +0000 (11 13:55 +0000)]
MDL-10092:
Decode HTML entities before processing.
Merged from STABLE_18
jamiesensei [Tue, 11 Sep 2007 09:01:21 +0000 (11 09:01 +0000)]
removing require that is not needed
jamiesensei [Tue, 11 Sep 2007 08:23:00 +0000 (11 08:23 +0000)]
fix to make breadcrumbs module independent
diml [Tue, 11 Sep 2007 08:09:02 +0000 (11 08:09 +0000)]
db scheme note for search engine
diml [Tue, 11 Sep 2007 08:03:40 +0000 (11 08:03 +0000)]
ensuring php5.0 php4.3 compatibility in cron runs
jgutierr25 [Tue, 11 Sep 2007 07:54:55 +0000 (11 07:54 +0000)]
Pb with autologinguest
nicolasconnault [Tue, 11 Sep 2007 07:29:48 +0000 (11 07:29 +0000)]
MDL-10383 Reverting Petr's boolean cast on the array of allowed groups. It makes it impossible to get the "Group event" option in the calendar.
stronk7 [Mon, 10 Sep 2007 22:42:04 +0000 (10 22:42 +0000)]
Now both check_constraint_exists() and find_check_constraint_name()
are working under mysql, postgresql and mssql. 1st step of MDL-9356
stronk7 [Mon, 10 Sep 2007 22:30:26 +0000 (10 22:30 +0000)]
Now Oracle is also able to detect its check constraints per field.
stronk7 [Mon, 10 Sep 2007 22:22:23 +0000 (10 22:22 +0000)]
Adding two new functions to search for check constraints from ddl stuff.
Unused and unfinished for now. I need them in CVS.
stronk7 [Mon, 10 Sep 2007 22:00:24 +0000 (10 22:00 +0000)]
Preparing getCheckConstraintsFromDB() to retrieve the check constraint
defined for one field. Not used yet but I need it in CVS now.
diml [Mon, 10 Sep 2007 19:48:31 +0000 (10 19:48 +0000)]
Fixes wildcard exception occurence on deleting resources.
diml [Mon, 10 Sep 2007 17:26:10 +0000 (10 17:26 +0000)]
add new itemid field for indexing subitems.
diml [Mon, 10 Sep 2007 17:25:35 +0000 (10 17:25 +0000)]
let lethal exceptions from Lucene passthrough and the cron script finish normally
stronk7 [Mon, 10 Sep 2007 17:13:12 +0000 (10 17:13 +0000)]
Allow the upgrade_plugins() function to autodetect if the header
has been printed, so it runs in "embedded" mode. Useful to run
submodule installation/upgrade in the same page than the parent. MDL-11183
moodler [Mon, 10 Sep 2007 14:55:32 +0000 (10 14:55 +0000)]
Removed unnecessary WHERE statement in SQL MDL-11146
jamiesensei [Mon, 10 Sep 2007 13:28:18 +0000 (10 13:28 +0000)]
test for has_capability before displaying choosecoursefile control as if user does not have permission then control is useless.
tjhunt [Mon, 10 Sep 2007 11:07:39 +0000 (10 11:07 +0000)]
Take out duplicate $Id$ CVS tags.
moodler [Mon, 10 Sep 2007 07:02:52 +0000 (10 07:02 +0000)]
Fixed notice when using textlib
nicolasconnault [Mon, 10 Sep 2007 04:58:09 +0000 (10 04:58 +0000)]
MDL-10723 Another file that escaped the update
stronk7 [Sun, 9 Sep 2007 16:28:16 +0000 (9 16:28 +0000)]
Extending getCheckConstraintsFromDB() to support a new parameter
used to filter what field in the table we want to know
its check constraints
stronk7 [Sun, 9 Sep 2007 16:09:00 +0000 (9 16:09 +0000)]
Now mysql returns getCheckConstraintsFromDB() in a compatible
way (array of name & description objects) with the check
constraints found in the table
stronk7 [Sat, 8 Sep 2007 22:58:50 +0000 (8 22:58 +0000)]
Fix excess of slashing in course names when restoring. MDL-11151
Merged from MOODLE_18_MERGED
stronk7 [Sat, 8 Sep 2007 22:49:13 +0000 (8 22:49 +0000)]
Fix link in email to new admin report. MDL-7850
Merged from MOODLE_18_STABLE
stronk7 [Sat, 8 Sep 2007 22:45:45 +0000 (8 22:45 +0000)]
Adding some strings for the new backups report. MDL-7850
Merged from MOODLE_18_STABLE
stronk7 [Sat, 8 Sep 2007 22:41:27 +0000 (8 22:41 +0000)]
Redirecting old backup log to the new one. MDL-7850
Merged from MOODLE_18_STABLE
stronk7 [Sat, 8 Sep 2007 22:36:29 +0000 (8 22:36 +0000)]
Adding new report to display scheduled backup logs. MDL-7850
Merged from MOODLE_18_STABLE
skodak [Sat, 8 Sep 2007 20:53:05 +0000 (8 20:53 +0000)]
MDL-7380 converted various places to use new groups API
moodler [Sat, 8 Sep 2007 03:57:39 +0000 (8 03:57 +0000)]
installer.php lang files by installer_builder (
20070908)
diml [Fri, 7 Sep 2007 18:56:17 +0000 (7 18:56 +0000)]
add postgress model for search
diml [Fri, 7 Sep 2007 18:54:47 +0000 (7 18:54 +0000)]
fixes docdate bad default value format. Was '0', should have been 0.
diml [Fri, 7 Sep 2007 18:52:00 +0000 (7 18:52 +0000)]
enhance cron response when disabled.
diml [Fri, 7 Sep 2007 18:51:16 +0000 (7 18:51 +0000)]
fixes bad path in checkDB()
jmg324 [Fri, 7 Sep 2007 14:49:30 +0000 (7 14:49 +0000)]
MDL-11159 adding a name to block config form for javascript support