Merge branch '4524_cleanup'

* 4524_cleanup: (40 commits)
  Update po/*.po files.
  (link_t): remove unused member linkcount.
  src/filemanager/file.c: fix comment.
  src/filemanager/file.c: rename structure: link -> link_t.
  (fetch_hosts): refactoring.
  hostname complition: refactoring: use GPtrArray.
  (load_codepages_list_from_file): use g_ptr_array_new_full().
  src/selcodepage.c: fix coding style.
  (tree_move): fix coding style.
  (info_show_info): don't create VFS path if EXT2 attributes aren't supported.
  file_op_context_t: remove op_preserve member.
  (shell_execute): fix coding style.
  (tar_seek_archive): improve diagnostic for truncated archive.
  Move OS-specific stuff from lib/global.h to lib/unixcompat.h.
  Merge lib/utilunix.h into lib/util.h.
  Merge lib/strescape.h into lib/strutil.h. Rename functions.
  Set the default IO size to 256KiB.
  (find_cmd): add intermediate variable to simplify formatting.
  mceditor: massive use of edit_arg_t as function argument.
  mceditor: new APIs.
  ...

Update po/*.po files.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

(link_t): remove unused member linkcount.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

src/filemanager/file.c: fix comment.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

src/filemanager/file.c: rename structure: link -> link_t.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

(fetch_hosts): refactoring.

Reduce variablle scope.
Refactor loops.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

hostname complition: refactoring: use GPtrArray.

(load_codepages_list_from_file): use g_ptr_array_new_full().

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

src/selcodepage.c: fix coding style.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

(tree_move): fix coding style.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

(info_show_info): don't create VFS path if EXT2 attributes aren't supported.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

file_op_context_t: remove op_preserve member.

(file_mask_dialog): use local variable instead.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

(shell_execute): fix coding style.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

(tar_seek_archive): improve diagnostic for truncated archive.

If EOF has been read, don't attempt to seek past it.

Sync with GNU tar 21318f385627a30da5d92811dd80f70abbe80ee7.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

Move OS-specific stuff from lib/global.h to lib/unixcompat.h.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

Merge lib/utilunix.h into lib/util.h.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

Merge lib/strescape.h into lib/strutil.h. Rename functions.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

Set the default IO size to 256KiB.

src/filemanager/ioblksize.h: Add updated test results and increase value
from 128KiB to 256KiB.

This was previously 128KiB and increasing to 256KiB was seen to increase
throughput by 10-20% when reading cached files on modern systems.

Sync with GNU coreutils fcfba90d0d27a1bacf2020bac4dbec74ed181028.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

(find_cmd): add intermediate variable to simplify formatting.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

mceditor: massive use of edit_arg_t as function argument.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

mceditor: new APIs.

  * (edit_arg_init): initialize edit_arg_t object.
  * (edit_arg_assign): Apply new values to edit_arg_t object members.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

mceditor: drop edit_stack_type. Use edit_arg_t instead.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

(edit_get_file_name): move from editwidget.c to edit.c.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

mceditor: refactoring.

  * (mcedit_arg_t): rename to edit_arg_t and move to src/editor/edit.h.
  * (mcedit_arg_free): rename to edit_arg_free() and move to src/editor/edit.c.
  * (mcedit_arg_vpath_new): rename to edit_arg_vpath_new(), move to src/editor/edit.c
  and make public.
  * (mcedit_arg_new): rename to edit_arg_new(), move to src/editor/edit.c
  and make public.
  * src/editor/editwidget.c: sync with new editor APIs.
  * src/main.c: likewise.
  * src/args.c: likewise.
  * (mc_args_parse): show error in case of run MC as "mc -e" if MC is built
    without builtin editor.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

textconf.c: features: fix capital letters.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

(dview_init): move first run of redo_diff() to diff_view().

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

(create_panel): reduce variable scope.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

(mcview_new): use WRect to define a panel area.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

Modify WTree creation API.

 * (tree_init): use WRect to define widget area.
 * (create_panel): sync with modified API.
 * (tree_box): likewise.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

(info_new): use WRect to define a panel area.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

Change the file list panel creation APIs.

  * (panel_sized_empty_new): use WRect to define a panel area.
  * (panel_sized_with_dir_new): likewise.
  * (panel_sized_new): likewise.
  * (panel_empty_new): sync with modified API.
  * (panel_with_dir_new): likewise.
  * (panel_sized_with_dir_new): likewise.
  * (create_panel): likewise.
  * (restore_into_right_dir_panel): likewise.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

(put_tagged): trivial refactoring.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

(check_panel_timestamp): constify arguments, simplify checks.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

(mc_build_filenamev): refactoring.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

Don't create and install diff viewer man page if mc is built --without-diff-viewer.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

Don't create and install mcedit man page if mc is built --without-internal-edit.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

Clean up irrelevant comments.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

src/editor/editmenu.c: includes cleanup.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

mcedit: update C and C++ syntax highlightings.

Closes MidnightCommander/mc#195.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

(edit_get_search_line_type): refactoring.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

Ticket #4524: code cleanup before 4.8.32 release.

mcedit: fix losing column position when navigating up/down.
Regression from 49bc0ddebfda91ea90d19b286ca1c2198387cf77.

Closes MidnightCommander/mc#194.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

Merge branch '4533_external_editor_tokens'

* 4533_external_editor_tokens:
  Ticket #4533: External editor does not work with arguments in $EDITOR

Ticket #4533: External editor does not work with arguments in $EDITOR

When using an external editor (i.e. "Use internal edit" in the Configure
Options is unchecked) the environment variable EDITOR is used. However,
if $EDITOR contains a command line argument after the executable name,
these arguments are not processed properly, and the editor might not be
started at all.

How to reproduce: (Precondition: vi is available on the system)
  1) On the command line, execute: export EDITOR="vi +" && mc
(the + argument should let vi start at the document's end instead of the
beginning).
  2) Go to the Options menu -> Configuration -> uncheck "Use internal
edit".
  3) Move the cursor to a file that is larger than a single screen (e.g.
ABOUT-NLS in mc's source directory).
  4) Press F4 to start the external editor.

Result: Nothing visible happens

Expected result: vi is opened showing the end of the file ABOUT-NLS

The bug: my_system_make_arg_array() doesn't perform full-feature
parsing of the comman line.

  * (str_tokenize): mew function based on history_tokenize_internal()
from GNU readline-8.2.
  * (str_tokenize_word): mew function based on history_tokenize_word()
from GNU readline-8.2.
  * (my_system_make_arg_array): reimplement using str_tokenize().
  * (my_systemv_flags): use modified my_system_make_arg_array().
  * (fork_child_tokens): new test for string tokenization.
  * (fork_child_tokens2): likewise.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

Merge branch '4532_copy_move_attrs'

* 4532_copy_move_attrs:
  mceditor: support ext2fs attributes.
  Ticket #4451: preserve ext2fs attributes on copy/move operations.

mceditor: support ext2fs attributes.

Get attributes on file open and set ones on file save.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

Ticket #4451: preserve ext2fs attributes on copy/move operations.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

Merge branch '4530_skins'

* 4530_skins:
  skins: add modarin256 thin and root variant.
  skins: add modarcon16 thin and root variant.
  skins: add xoria thin and root variant.
  Ticket #4530: new skins.

skins: add modarin256 thin and root variant.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

skins: add modarcon16 thin and root variant.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

skins: add xoria thin and root variant.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

Ticket #4530: new skins.

Initial commit: xoria256.ini: clean up.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

Merge branch '4224_mcdiff_man'

* 4224_mcdiff_man:
  Ticket #4224: add mcdiff manual page.

Ticket #4224: add mcdiff manual page.

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

Merge branch '3088_terminal_cwd'

* 3088_terminal_cwd:
  Use ESC_STR macro in escape sequences.
  (update_xterm_title_path): change the escape sequence's terminator
  Ticket #3088: tell the current directory to the terminal

Use ESC_STR macro in escape sequences.

  * (update_xterm_title_path): use ESC_STR macro.
  * (update_terminal_cwd): likewise.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

(update_xterm_title_path): change the escape sequence's terminator

...from \a to \e\\. Various standards (at least ECMA-48 and DEC STD 070)
agree that an OSC is to be terminated by an ST, i.e. \e\\. Using BEL \a
is a nonstandard solution introduced and popularized by xterm.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

Ticket #3088: tell the current directory to the terminal

...using OSC 7 sequence, so it can open new tabs there.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

Merge branch '4521_fish_history'

* 4521_fish_history:
  Ticket #4521: really escape fish shell history.

Ticket #4521: really escape fish shell history.

Some of the "service" commands generated by the mc "leak" into the fish
subshell history available to the user. An example to reproduce:

  *  set user shell to fish and start mc (SHELL=/usr/bin/fish mc)
  *  navigate to any directory
  *  press Ctrl+o
  *  press \u2191 button (UP, go back in history)
  *  observe " cd (printf '%b' ... " command

This commit avoids the " cd (printf '%b' ... " commands in the fish
history.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

Merge branch '4525_mcedit_replace_regex'

* 4525_mcedit_replace_regex:
  (edit_search_init): call edit_search_fix_search_start_if_selection().
  Tickets #4525, #4526: mcedit: fix replacement using regular expressions.

(edit_search_init): call edit_search_fix_search_start_if_selection().

  * (edit_search): do not call edit_search_fix_search_start_if_selection()
  since it called in edit_search_init().
  * (edit_replace_cmd): likewise; join two ifs.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

Tickets #4525, #4526: mcedit: fix replacement using regular expressions.

The bug was introduced in 21feb38a8d9161c4004ff4d9d11eb6c010b200e1.

  * (edit_search_init): call edit_get_search_line_type().
  * (edit_search): do mot call edit_get_search_line_type() since it is
  called in edit_search_init().

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

Merge branch '4518_unrar7'

* 4518_unrar7:
  Ticket #4518: extfs: support unrar-7.

Ticket #4518: extfs: support unrar-7.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

Ticket #4519: mcedit: fix php.syntax.

Highlight comment located in any place of line, not from start only.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

Update doc/NEWS file

Signed-off-by: Yury V. Zaytsev <yury@shurup.com>

Update hints translations from Transifex

Signed-off-by: Yury V. Zaytsev <yury@shurup.com>

Update translations from Transifex

Signed-off-by: Yury V. Zaytsev <yury@shurup.com>

Merge branch '4490_cleanup'

* 4490_cleanup: (31 commits)
  Update po/*.po files.
  ext.d/image.sh: use exiftool in addition to exif to view image metadata.
  ext.d/image.sh: check $DISPLAY in the xpm View action.
  mc.ext.ini: support avif images.
  mc.ext.ini: add View action for webp images.
  Update copyright years.
  (main): call tty_check_term() right after mc_args_parse().
  Refactor learn keys.
  Use g_string_new_take().
  (test_glob_prepare_replace_str): remove unneeded type cast.
  maint/utils/update-years.sh: replaced unportable 'sed -i' command.
  maint/utils/update-years.sh: add src/man2hlp/man2hlp.in.
  src/man2hlp/man2hlp.in: collapse copyright years.
  (str_utf8_offset_to_pos): change type of variable.
  (mc_search_regex__get_max_num_of_replace_tokens): refactor loop.
  lib/widget/input_complete.c: remove intermediate variables.
  mcedit: add intermediate variables to make code more readable and debuggable.
  (is_blank): refactor loop.
  (edit_help): use help node of editor dialog.
  (tree_execute_cmd): move CK_Help handler to separate function tree_help()
  ...

Update po/*.po files.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

ext.d/image.sh: use exiftool in addition to exif to view image metadata.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

ext.d/image.sh: check $DISPLAY in the xpm View action.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

mc.ext.ini: support avif images.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

mc.ext.ini: add View action for webp images.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

Update copyright years.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

(main): call tty_check_term() right after mc_args_parse().

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

Refactor learn keys.

  * (learn_store_key):
  * (learn_key): use GString for key buffer.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

Use g_string_new_take().

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

(test_glob_prepare_replace_str): remove unneeded type cast.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

maint/utils/update-years.sh: replaced unportable 'sed -i' command.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

maint/utils/update-years.sh: add src/man2hlp/man2hlp.in.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

src/man2hlp/man2hlp.in: collapse copyright years.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

(str_utf8_offset_to_pos): change type of variable.

GString is pointless here.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

(mc_search_regex__get_max_num_of_replace_tokens): refactor loop.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

lib/widget/input_complete.c: remove intermediate variables.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

mcedit: add intermediate variables to make code more readable and debuggable.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

(is_blank): refactor loop.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

(edit_help): use help node of editor dialog.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

(tree_execute_cmd): move CK_Help handler to separate function tree_help()

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

(menubar_execute_cmd): move CK_Help handler to separate function menubar_help().

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

(dlg_execute_cmd): move CK_Help handler to separate function dlg_help().

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

(mcview_execute_cmd): don't handle CK_Help here.

Use default handler via dlg_execute_cmd().

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

(move_to_top): fix a 14-years error in condition.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

src/help.c: reduce variable scopes.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

src/help.c: refactor loops.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

src/help.c: fix coding style.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

doc/ru/mc.1: various fixups.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

(eval_marks): move from editcmd.c to edit.c.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

(edit_block_delete_cmd): return boolean.

(edit_block_delete): likewize.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

Ticket #4490: code cleanup before 4.8.31 release.

(mcdiffview_dialog_search): indentation.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>