| commit | db4d3b9dedd857ae5f90301a654b7997132be7ae | |
| author | Tejun Heo <htejun@gmail.com> | |
| Sun, 16 Aug 2009 12:21:21 +0000 (16 21:21 +0900) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Thu, 24 Sep 2009 15:27:28 +0000 (24 08:27 -0700) | ||
| tree | 17ba49782d9228d41a3c9eb6a730bcdc849cae75 | treesnapshot (tar.gz zip) |
| parent | 98d53d73e1a28f0f55de4141ef91799aba0507b6 | commitdiff |
libata: fix off-by-one error in ata_tf_read_block()
commit ac8672ea922bde59acf50eaa1eaa1640a6395fd2 upstream.
ata_tf_read_block() has off-by-one error when converting CHS address
to LBA. The bug isn't very visible because ata_tf_read_block() is
used only when generating sense data for a failed RW command and CHS
addressing isn't used too often these days.
This problem was spotted by Atsushi Nemoto.
Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
commit ac8672ea922bde59acf50eaa1eaa1640a6395fd2 upstream.
ata_tf_read_block() has off-by-one error when converting CHS address
to LBA. The bug isn't very visible because ata_tf_read_block() is
used only when generating sense data for a failed RW command and CHS
addressing isn't used too often these days.
This problem was spotted by Atsushi Nemoto.
Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| drivers/ata/libata-core.c | diffblobblamehistory |