| commit | 8ec6dba2581754e375be66f7bedd708d856d8b30 | |
| author | Jan Rekorajski <baggins@sith.mimuw.edu.pl> | |
| Mon, 16 Nov 2009 11:57:02 +0000 (16 11:57 +0000) | ||
| committer | Alex Elder <aelder@sgi.com> | |
| Tue, 17 Nov 2009 16:26:38 +0000 (17 10:26 -0600) | ||
| tree | d6cfdee839d6fb0b236a8d4272e607a9f5c4241c | treesnapshot (tar.gz zip) |
| parent | a9366e61b03f55a6e009e687ad10e706714c9907 | commitdiff |
XFS bug in log recover with quota (bugzilla id 855)
Hi,
I was hit by a bug in linux 2.6.31 when XFS is not able to recover the
log after a crash if fs was mounted with quotas. Gory details in XFS
bugzilla: http://oss.sgi.com/bugzilla/show_bug.cgi?id=855.
It looks like wrong struct is used in buffer length check, and the following
patch should fix the problem.
xfs_dqblk_t has a size of 104+32 bytes, while xfs_disk_dquot_t is 104 bytes
long, and this is exactly what I see in system logs - "XFS: dquot too small
(104) in xlog_recover_do_dquot_trans."
Signed-off-by: Jan Rekorajski <baggins@sith.mimuw.edu.pl>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Alex Elder <aelder@sgi.com>
Hi,
I was hit by a bug in linux 2.6.31 when XFS is not able to recover the
log after a crash if fs was mounted with quotas. Gory details in XFS
bugzilla: http://oss.sgi.com/bugzilla/show_bug.cgi?id=855.
It looks like wrong struct is used in buffer length check, and the following
patch should fix the problem.
xfs_dqblk_t has a size of 104+32 bytes, while xfs_disk_dquot_t is 104 bytes
long, and this is exactly what I see in system logs - "XFS: dquot too small
(104) in xlog_recover_do_dquot_trans."
Signed-off-by: Jan Rekorajski <baggins@sith.mimuw.edu.pl>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Alex Elder <aelder@sgi.com>
| fs/xfs/xfs_log_recover.c | diffblobblamehistory |