net: fix rds_iovec page count overflow
commitee80363c646143e7ab18fbf46e8349370c8fb8bf
authorLinus Torvalds <torvalds@linux-foundation.org>
Thu, 28 Oct 2010 15:40:55 +0000 (28 15:40 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 22 Apr 2011 15:50:08 +0000 (22 08:50 -0700)
tree3c5670ca68fc933b021dbfc7cbd4f3ee0fd06d9a
parent73f209e0b23396a6d3882587bd49df104f5dd430
net: fix rds_iovec page count overflow

commit 1b1f693d7ad6d193862dcb1118540a030c5e761f upstream.

As reported by Thomas Pollet, the rdma page counting can overflow.  We
get the rdma sizes in 64-bit unsigned entities, but then limit it to
UINT_MAX bytes and shift them down to pages (so with a possible "+1" for
an unaligned address).

So each individual page count fits comfortably in an 'unsigned int' (not
even close to overflowing into signed), but as they are added up, they
might end up resulting in a signed return value. Which would be wrong.

Catch the case of tot_pages turning negative, and return the appropriate
error code.

Reported-by: Thomas Pollet <thomas.pollet@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Andy Grover <andy.grover@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
[v2: nr is unsigned in the old code]
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Acked-by: Brad Figg <brad.figg@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/rds/rdma.c