| commit | cf4ca69d46d49eb6fd8803f6618dd60184892835 | |
| author | Jens Axboe <jaxboe@fusionio.com> | |
| Sun, 5 Jun 2011 04:01:13 +0000 (5 06:01 +0200) | ||
| committer | Andi Kleen <ak@linux.intel.com> | |
| Mon, 1 Aug 2011 20:54:58 +0000 (1 13:54 -0700) | ||
| tree | 8ade0e20892dfaf63be5ad30b9c7c97a89f1d0dc | treesnapshot (tar.gz zip) |
| parent | df9ceceff3742d28c59093c6c60b3ef1359fdf96 | commitdiff |
cfq-iosched: fix locking around ioc->ioc_data assignment
commit ab4bd22d3cce6977dc039664cc2d052e3147d662 upstream.
Since we are modifying this RCU pointer, we need to hold
the lock protecting it around it.
This fixes a potential reuse and double free of a cfq
io_context structure. The bug has been in CFQ for a long
time, it hit very few people but those it did hit seemed
to see it a lot.
Tracked in RH bugzilla here:
https://bugzilla.redhat.com/show_bug.cgi?id=577968
Credit goes to Paul Bolle for figuring out that the issue
was around the one-hit ioc->ioc_data cache. Thanks to his
hard work the issue is now fixed.
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
commit ab4bd22d3cce6977dc039664cc2d052e3147d662 upstream.
Since we are modifying this RCU pointer, we need to hold
the lock protecting it around it.
This fixes a potential reuse and double free of a cfq
io_context structure. The bug has been in CFQ for a long
time, it hit very few people but those it did hit seemed
to see it a lot.
Tracked in RH bugzilla here:
https://bugzilla.redhat.com/show_bug.cgi?id=577968
Credit goes to Paul Bolle for figuring out that the issue
was around the one-hit ioc->ioc_data cache. Thanks to his
hard work the issue is now fixed.
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
| block/cfq-iosched.c | diffblobblamehistory |