| commit | 6c1c9cf6f1336fc332d2e1fc0453e2bc16a7089b | |
| author | David S. Miller <davem@davemloft.net> | |
| Thu, 22 Dec 2011 21:23:59 +0000 (22 13:23 -0800) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Fri, 6 Jan 2012 22:17:23 +0000 (6 14:17 -0800) | ||
| tree | f08a81c516c76b875863f5061be065c720429e75 | treesnapshot (tar.gz zip) |
| parent | ec89dadb52f3dee5e49588613ad3bf66cf140141 | commitdiff |
sparc64: Fix MSIQ HV call ordering in pci_sun4v_msiq_build_irq().
[ Upstream commit 7cc8583372a21d98a23b703ad96cab03180b5030 ]
This silently was working for many years and stopped working on
Niagara-T3 machines.
We need to set the MSIQ to VALID before we can set it's state to IDLE.
On Niagara-T3, setting the state to IDLE first was causing HV_EINVAL
errors. The hypervisor documentation says, rather ambiguously, that
the MSIQ must be "initialized" before one can set the state.
I previously understood this to mean merely that a successful setconf()
operation has been performed on the MSIQ, which we have done at this
point. But it seems to also mean that it has been set VALID too.
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
[ Upstream commit 7cc8583372a21d98a23b703ad96cab03180b5030 ]
This silently was working for many years and stopped working on
Niagara-T3 machines.
We need to set the MSIQ to VALID before we can set it's state to IDLE.
On Niagara-T3, setting the state to IDLE first was causing HV_EINVAL
errors. The hypervisor documentation says, rather ambiguously, that
the MSIQ must be "initialized" before one can set the state.
I previously understood this to mean merely that a successful setconf()
operation has been performed on the MSIQ, which we have done at this
point. But it seems to also mean that it has been set VALID too.
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| arch/sparc/kernel/pci_sun4v.c | diffblobblamehistory |