| commit | 42e857c955b65b25062e5af605c4164e5e32b144 | |
| author | Jan Kara <jack@suse.cz> | |
| Thu, 22 Dec 2011 15:49:05 +0000 (22 16:49 +0100) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Thu, 12 Jan 2012 19:35:06 +0000 (12 11:35 -0800) | ||
| tree | 98a0c0e4688546641203589717a5748cb695e101 | treesnapshot (tar.gz zip) |
| parent | d8bbed420a3f1a3c7290a7bb9f3b424fd24c0b04 | commitdiff |
ext3: Don't warn from writepage when readonly inode is spotted after error
commit 33c104d415e92a51aaf638dc3d93920cfa601e5c upstream.
WARN_ON_ONCE(IS_RDONLY(inode)) tends to trip when filesystem hits error and is
remounted read-only. This unnecessarily scares users (well, they should be
scared because of filesystem error, but the stack trace distracts them from the
right source of their fear ;-). We could as well just remove the WARN_ON but
it's not hard to fix it to not trip on filesystem with errors and not use more
cycles in the common case so that's what we do.
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
commit 33c104d415e92a51aaf638dc3d93920cfa601e5c upstream.
WARN_ON_ONCE(IS_RDONLY(inode)) tends to trip when filesystem hits error and is
remounted read-only. This unnecessarily scares users (well, they should be
scared because of filesystem error, but the stack trace distracts them from the
right source of their fear ;-). We could as well just remove the WARN_ON but
it's not hard to fix it to not trip on filesystem with errors and not use more
cycles in the common case so that's what we do.
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| fs/ext3/inode.c | diffblobblamehistory |