| commit | 0876d729c595830f202f08bc858075d0ce1a8c67 | |
| author | Henrique de Moraes Holschuh <hmh@hmh.eng.br> | |
| Sat, 14 Nov 2009 02:56:24 +0000 (14 00:56 -0200) | ||
| committer | Henrique de Moraes Holschuh <hmh@hmh.eng.br> | |
| Sat, 14 Nov 2009 02:56:24 +0000 (14 00:56 -0200) | ||
| tree | c09a1f8373dc5f841fcccde2f47689f83f249a0e | treesnapshot (tar.gz zip) |
| parent | 4d886ca44888230e7ba98c34ca0182cd29d380bd | commitdiff |
thinkpad-acpi: fix detection of old ThinkPads
There is a problem in the quirk tables used by tpacpi_is_fw_known()
and tpacpi_check_outdated_fw(), which causes outdated BIOSes that are
lacking the EC firmware ID DMI field to never match.
This breaks module loading on, e.g. a T23 with outdated BIOS, and the
module will refuse to load unless the "force_load=1" parameter is
given.
Fix the quirk tables so that they can also match the outdated BIOSes,
which in turn will both fix the module loading, and also warn the user
that he is using outdated firmware and should upgrade.
This fixes a serious regression, introduced by commit
e675abafcc0df38125e6e94a9ba91c92fe774f52,
"thinkpad-acpi: be more strict when detecting a ThinkPad".
Tracked by bugzilla #14597.
Reported-by: Paul Kimoto <kimoto@lightlink.com>
Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Tested-by: Paul Kimoto <kimoto@lightlink.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
There is a problem in the quirk tables used by tpacpi_is_fw_known()
and tpacpi_check_outdated_fw(), which causes outdated BIOSes that are
lacking the EC firmware ID DMI field to never match.
This breaks module loading on, e.g. a T23 with outdated BIOS, and the
module will refuse to load unless the "force_load=1" parameter is
given.
Fix the quirk tables so that they can also match the outdated BIOSes,
which in turn will both fix the module loading, and also warn the user
that he is using outdated firmware and should upgrade.
This fixes a serious regression, introduced by commit
e675abafcc0df38125e6e94a9ba91c92fe774f52,
"thinkpad-acpi: be more strict when detecting a ThinkPad".
Tracked by bugzilla #14597.
Reported-by: Paul Kimoto <kimoto@lightlink.com>
Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Tested-by: Paul Kimoto <kimoto@lightlink.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
| drivers/platform/x86/thinkpad_acpi.c | diffblobblamehistory |