| commit | dca48cf520933c028f807f65175c29482a209f23 | |
| author | Martin von Zweigbergk <martinvonz@gmail.com> | |
| Tue, 15 Jan 2013 05:47:38 +0000 (14 21:47 -0800) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Tue, 15 Jan 2013 17:38:07 +0000 (15 09:38 -0800) | ||
| tree | 46c8a1fe06b4aafe0f5b72d3b61b8dd8afb03a29 | treesnapshot (tar.gz zip) |
| parent | 39ea722d829ddc5bb253fbe12333d768965f4fe7 | commitdiff |
reset.c: remove unnecessary variable 'i'
Throughout most of parse_args(), the variable 'i' remains at 0. Many
references are still made to the variable even when it could only have
the value 0. This made at least me, who has relatively little
experience with C programming styles, think that parts of the function
was meant to be part of a loop. To avoid such confusion, remove the
variable and also the 'argc' parameter and check for NULL trailing
argv instead.
Signed-off-by: Martin von Zweigbergk <martinvonz@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Throughout most of parse_args(), the variable 'i' remains at 0. Many
references are still made to the variable even when it could only have
the value 0. This made at least me, who has relatively little
experience with C programming styles, think that parts of the function
was meant to be part of a loop. To avoid such confusion, remove the
variable and also the 'argc' parameter and check for NULL trailing
argv instead.
Signed-off-by: Martin von Zweigbergk <martinvonz@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/reset.c | diffblobblamehistory |