| commit | ac751a0b4332268ad9ba69c7dd48768dbdbd25c8 | |
| author | John Keeping <john@keeping.me.uk> | |
| Mon, 4 Mar 2013 00:03:37 +0000 (4 00:03 +0000) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Mon, 4 Mar 2013 03:43:54 +0000 (3 19:43 -0800) | ||
| tree | dd11e489c1220e81d6efaa1100d7768922890124 | treesnapshot (tar.gz zip) |
| parent | 4d0d0c3c59800e07d899e53121902833e3fd0cc7 | commitdiff |
Revert "graph.c: mark private file-scope symbols as static"
This reverts commit ba35480439d05b8f6cca50527072194fe3278bbb.
CGit uses these symbols to output the correct HTML around graph
elements. Making these symbols private means that CGit cannot be
updated to use Git 1.8.0 or newer, so let's not do that.
On top of the revert, also add comments so that we avoid reintroducing
this problem in the future and suggest to those modifying this API
that they might want to discuss it with the CGit developers.
Signed-off-by: John Keeping <john@keeping.me.uk>
Acked-by: Jason A. Donenfeld <Jason@zx2c4.com>
Acked-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This reverts commit ba35480439d05b8f6cca50527072194fe3278bbb.
CGit uses these symbols to output the correct HTML around graph
elements. Making these symbols private means that CGit cannot be
updated to use Git 1.8.0 or newer, so let's not do that.
On top of the revert, also add comments so that we avoid reintroducing
this problem in the future and suggest to those modifying this API
that they might want to discuss it with the CGit developers.
Signed-off-by: John Keeping <john@keeping.me.uk>
Acked-by: Jason A. Donenfeld <Jason@zx2c4.com>
Acked-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| graph.c | diffblobblamehistory | |
| graph.h | diffblobblamehistory |