| commit | 877449c136539cf8b9b4ed9cfe33a796b7b93f93 | |
| author | Junio C Hamano <gitster@pobox.com> | |
| Mon, 13 Jun 2011 19:17:52 +0000 (13 12:17 -0700) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Mon, 13 Jun 2011 19:18:29 +0000 (13 12:18 -0700) | ||
| tree | 3f84c20992854cb84aa6a927b1419180463133d8 | treesnapshot (tar.gz zip) |
| parent | 15ffb7cde48b73b3d5ce259443db7d2e0ba13750 | commitdiff |
git-submodule.sh: clarify the "should we die now" logic
Earlier the decision to stop or continue was made on the $action variable
that was set by inspecting $update_module variable. The former is a
redundant variable and will be removed in another topic.
Decide upon inspecting $update_module if a failure should cascade up to
cause us immediately stop, and use a variable that means just that, to
clarify the logic.
Incidentally this also makes the merge with the other topic slightly
easier and cleaner to understand.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Earlier the decision to stop or continue was made on the $action variable
that was set by inspecting $update_module variable. The former is a
redundant variable and will be removed in another topic.
Decide upon inspecting $update_module if a failure should cascade up to
cause us immediately stop, and use a variable that means just that, to
clarify the logic.
Incidentally this also makes the merge with the other topic slightly
easier and cleaner to understand.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| git-submodule.sh | diffblobblamehistory |