| commit | b29763aa9bcbb99a59aec3820e30ff1864cfa765 | |
| author | Steffen Prohaska <prohaska@zib.de> | |
| Tue, 26 Aug 2014 15:23:24 +0000 (26 17:23 +0200) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Thu, 28 Aug 2014 17:25:14 +0000 (28 10:25 -0700) | ||
| tree | d3dcda097520b70a990e48e7ea52b9bbb9ad206d | treesnapshot (tar.gz zip) |
| parent | 02710228dd79d9f9c6fa180233491639b603c06d | commitdiff |
copy_fd(): do not close the input file descriptor
The caller, not this function, opened the file descriptor; it is
selfish for the callee to close it when it is done reading from it.
The caller may want an option to rewind and re-read the contents
after it returns.
Simplify the loop to copy the input in full to the output; its
body essentially is what a call to write_in_full() helper does.
Signed-off-by: Steffen Prohaska <prohaska@zib.de>
Helped-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
The caller, not this function, opened the file descriptor; it is
selfish for the callee to close it when it is done reading from it.
The caller may want an option to rewind and re-read the contents
after it returns.
Simplify the loop to copy the input in full to the output; its
body essentially is what a call to write_in_full() helper does.
Signed-off-by: Steffen Prohaska <prohaska@zib.de>
Helped-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| copy.c | diffblobblamehistory | |
| lockfile.c | diffblobblamehistory |