| commit | 1427a7ff70bce0c1040831d5d674c83ebcda6d7d | |
| author | Junio C Hamano <gitster@pobox.com> | |
| Mon, 4 May 2015 18:08:10 +0000 (4 11:08 -0700) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Tue, 5 May 2015 17:17:56 +0000 (5 10:17 -0700) | ||
| tree | b2ae32819798ef09ab9222ebe19fc0239e4ba2b7 | treesnapshot (tar.gz zip) |
| parent | 383c3427afa3201eb05e931825c5c2f20616b58b | commitdiff |
write_sha1_file(): do not use a separate sha1[] array
In the beginning, write_sha1_file() did not have a way to tell the
caller the name of the object it wrote to the caller. This was
changed in d6d3f9d0 (This implements the new "recursive tree"
write-tree., 2005-04-09) by adding the "returnsha1" parameter to the
function so that the callers who are interested in the value can
optionally pass a pointer to receive it.
It turns out that all callers do want to know the name of the object
it just has written. Nobody passes a NULL to this parameter, hence
it is not necessary to use a separate sha1[] array to receive the
result from write_sha1_file_prepare(), and copy the result to the
returnsha1 supplied by the caller.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
In the beginning, write_sha1_file() did not have a way to tell the
caller the name of the object it wrote to the caller. This was
changed in d6d3f9d0 (This implements the new "recursive tree"
write-tree., 2005-04-09) by adding the "returnsha1" parameter to the
function so that the callers who are interested in the value can
optionally pass a pointer to receive it.
It turns out that all callers do want to know the name of the object
it just has written. Nobody passes a NULL to this parameter, hence
it is not necessary to use a separate sha1[] array to receive the
result from write_sha1_file_prepare(), and copy the result to the
returnsha1 supplied by the caller.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| sha1_file.c | diffblobblamehistory |