| commit | 74fd8728e2abd46a6276f6d48bfc6c9f01d74570 | |
| author | Jakub Narebski <jnareb@gmail.com> | |
| Thu, 7 May 2009 17:11:29 +0000 (7 19:11 +0200) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Sat, 9 May 2009 08:35:15 +0000 (9 01:35 -0700) | ||
| tree | a57309997897c223d9b930746b95589bcc91a22d | treesnapshot (tar.gz zip) |
| parent | 5a0e4a2a326966aabb566164a7571291e34adabd | commitdiff |
gitweb: Remove function prototypes (cleanup)
Use of function prototypes is considered bad practice in Perl. The
ones used here didn't accomplish anything anyhow, so they've been
removed.
>From perlsub(1):
[...] the intent of this feature [prototypes] is primarily to let
you define subroutines that work like built-in functions [...]
you can generate new syntax with it [...]
We don't want to have subroutines behaving exactly like built-in
functions, we don't want to define new syntax / syntactic sugar, so
prototypes in gitweb are not needed... and they can have unintended
consequences.
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Use of function prototypes is considered bad practice in Perl. The
ones used here didn't accomplish anything anyhow, so they've been
removed.
>From perlsub(1):
[...] the intent of this feature [prototypes] is primarily to let
you define subroutines that work like built-in functions [...]
you can generate new syntax with it [...]
We don't want to have subroutines behaving exactly like built-in
functions, we don't want to define new syntax / syntactic sugar, so
prototypes in gitweb are not needed... and they can have unintended
consequences.
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| gitweb/gitweb.perl | diffblobblamehistory |