Clear fd after closing to avoid double-close error
commit37cb1dd671e5e22cee363f98637a5a58f16be054
authorJens Lindstrom <jl@opera.com>
Tue, 22 Oct 2013 13:36:02 +0000 (22 15:36 +0200)
committerJunio C Hamano <gitster@pobox.com>
Wed, 23 Oct 2013 16:07:09 +0000 (23 09:07 -0700)
treeacf25b123b55691bac708b8fa0e5cd3e9c7b75fe
parent5f737ac91bd869e65bff401ad1108581ac504e22
Clear fd after closing to avoid double-close error

In send_pack(), clear the fd passed to pack_objects() by setting
it to -1, since pack_objects() closes the fd (via a call to
run_command()).  Likewise, in get_pack(), clear the fd passed to
run_command().

Not doing so risks having git_transport_push(), caller of
send_pack(), closing the fd again, possibly incorrectly closing
some other open file; or similarly with fetch_refs_from_pack(),
indirect caller of get_pack().

Signed-off-by: Jens Lindström <jl@opera.com>
Acked-by: Jeff King <peff@peff.net>
Acked-by: Duy Nguyen <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
fetch-pack.c
send-pack.c