| commit | dd63f169d9381a77db469325688a2bef1a79a9e1 | |
| author | Jeff King <peff@peff.net> | |
| Tue, 20 May 2014 06:49:20 +0000 (20 02:49 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Tue, 20 May 2014 18:09:03 +0000 (20 11:09 -0700) | ||
| tree | 9f67675b9d77ce9ec6cf4003b8b57181915d86de | treesnapshot (tar.gz zip) |
| parent | 7bbc4e8fdb33e0a8e42e77cc05460d4c4f615f4d | commitdiff |
move "--follow needs one pathspec" rule to diff_setup_done
Because of the way "--follow" is implemented, we must have
exactly one pathspec. "git log" enforces this restriction,
but other users of the revision traversal code do not. For
example, "git format-patch --follow" will segfault during
try_to_follow_renames, as we have no pathspecs at all.
We can push this check down into diff_setup_done, which is
probably a better place anyway. It is the diff code that
introduces this restriction, so other parts of the code
should not need to care themselves.
Reported-by: "Michael S. Tsirkin" <mst@redhat.com>
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Because of the way "--follow" is implemented, we must have
exactly one pathspec. "git log" enforces this restriction,
but other users of the revision traversal code do not. For
example, "git format-patch --follow" will segfault during
try_to_follow_renames, as we have no pathspecs at all.
We can push this check down into diff_setup_done, which is
probably a better place anyway. It is the diff code that
introduces this restriction, so other parts of the code
should not need to care themselves.
Reported-by: "Michael S. Tsirkin" <mst@redhat.com>
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/log.c | diffblobblamehistory | |
| diff.c | diffblobblamehistory |