| commit | 4a15758f2ef97970694012cfd6da7c8449bc68c2 | |
| author | Jeff King <peff@peff.net> | |
| Wed, 25 Jul 2012 16:16:19 +0000 (26 00:16 +0800) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Wed, 25 Jul 2012 17:23:54 +0000 (25 10:23 -0700) | ||
| tree | 6b013d6ee1975c514297e22427ef23dbe1ac5e0c | treesnapshot (tar.gz zip) |
| parent | 476109fa4c261c57cf20858b1879d5fede32e32c | commitdiff |
help.c::uniq: plug a leak
We observe that the j-1 element can serve the same purpose as the i-1
element that we use in the strcmp(); it is either:
1. Exactly i-1, when the loop begins (and until we see a duplicate).
2. The same pointer that was stored at i-1 (if it was not a duplicate,
and we just copied it into place).
3. A pointer to an equivalent string (i.e., we rejected i-1 _because_
it was identical to j-1).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
We observe that the j-1 element can serve the same purpose as the i-1
element that we use in the strcmp(); it is either:
1. Exactly i-1, when the loop begins (and until we see a duplicate).
2. The same pointer that was stored at i-1 (if it was not a duplicate,
and we just copied it into place).
3. A pointer to an equivalent string (i.e., we rejected i-1 _because_
it was identical to j-1).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| help.c | diffblobblamehistory |