| commit | 25ae7cfd19c8f21721363c64163cd5d9d1135b20 | |
| author | Felipe Contreras <felipe.contreras@gmail.com> | |
| Thu, 20 Sep 2012 02:15:15 +0000 (20 04:15 +0200) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Thu, 20 Sep 2012 16:52:36 +0000 (20 09:52 -0700) | ||
| tree | 14c218505ed262a0a0ea043e30a450228f9f7451 | treesnapshot (tar.gz zip) |
| parent | 304b7d99a705e8c125650dda347a571402222a3e | commitdiff |
completion: fix shell expansion of items
As reported by Jeroen Meijer[1]; the current code doesn't deal properly
with items (tags, branches, etc.) that have ${} in them because they get
expaned by bash while using compgen.
A simple solution is to quote the items so they get expanded properly
(\$\{\}).
In order to achieve that I took bash-completion's quote() function,
which is rather simple, and renamed it to __git_quote() as per Jeff
King's suggestion.
Solves the original problem for me.
[1] http://article.gmane.org/gmane.comp.version-control.git/201596
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
As reported by Jeroen Meijer[1]; the current code doesn't deal properly
with items (tags, branches, etc.) that have ${} in them because they get
expaned by bash while using compgen.
A simple solution is to quote the items so they get expanded properly
(\$\{\}).
In order to achieve that I took bash-completion's quote() function,
which is rather simple, and renamed it to __git_quote() as per Jeff
King's suggestion.
Solves the original problem for me.
[1] http://article.gmane.org/gmane.comp.version-control.git/201596
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| contrib/completion/git-completion.bash | diffblobblamehistory |