| commit | 1df48766137f2040e2e992d7d278d5aca26406cf | |
| author | Jakub Narebski <jnareb@gmail.com> | |
| Sun, 7 Feb 2010 20:52:25 +0000 (7 21:52 +0100) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Wed, 17 Feb 2010 19:18:12 +0000 (17 11:18 -0800) | ||
| tree | 015d89e7b088a0d94af8a726e1028f5e149466e1 | treesnapshot (tar.gz zip) |
| parent | 453541fcfcbc54aa3b0035667e5d5885d407d0a5 | commitdiff |
gitweb: Protect escaping functions against calling on undef
This is a bit of future-proofing esc_html and friends: when called
with undefined value they would now would return undef... which would
probably mean that error would still occur, but closer to the source
of problem.
This means that we can safely use
esc_html(shift) || "Internal Server Error"
in die_error() instead of
esc_html(shift || "Internal Server Error")
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This is a bit of future-proofing esc_html and friends: when called
with undefined value they would now would return undef... which would
probably mean that error would still occur, but closer to the source
of problem.
This means that we can safely use
esc_html(shift) || "Internal Server Error"
in die_error() instead of
esc_html(shift || "Internal Server Error")
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| gitweb/gitweb.perl | diffblobblamehistory |