From 9657392cec188f2693ed424c69a5fe009b4043c3 Mon Sep 17 00:00:00 2001 From: "Tom Breton (Tehom)" Date: Fri, 24 Dec 2010 16:20:26 -0500 Subject: [PATCH] Fixed reversed logic in byte-compile's call to elinstall-proceed-p --- elinstall.el | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/elinstall.el b/elinstall.el index 299b5c4..ba9f75a 100644 --- a/elinstall.el +++ b/elinstall.el @@ -224,7 +224,7 @@ PACKAGE can be `t' or a string naming a package." elinstall:*pkg-restraints* elinstall:*user-restraints*)) (apply func args))) -;;;_ , elinstall-proceed-p +;;;_ , elinstall-proceed-p (defun elinstall-proceed-p (topic message-params &optional already-p) "Return non-nil if actions on TOPIC should proceed. @@ -238,7 +238,7 @@ MESSAGE-PARAMS is a cons of: * The arguments to the formatter. ALREADY-P is an extended boolean whether the task has been done before, if caller can tell." - + ;;$$FACTOR ME (check-type topic symbol) (declare (special elinstall:*pkg-restraints* @@ -286,6 +286,8 @@ ALREADY-P is an extended boolean whether the task has been done (ask (y-or-n-p (apply #'format ask-prompt message-args))))))) +;;;_ , elinstall-proceed-at-all-p +;;$$WRITE ME Whether to proceed at all on a given topic. ;;;_ , Work ;;;_ . Doing actions @@ -796,7 +798,7 @@ PRIORITY must be an integer or nil." ;;$$IMPROVE ME If it is a symlink pointing to the same place, ;;do nothing. - ;;$$IMPROVE ME The condition here is not updating but + ;;$$IMPROVE ME The condition here is really not updating but ;;bulldozing a possibly different symlink. Add another ;;treatment symbol meaning to bulldoze what's in the way. ((elinstall-proceed-p 'preloads-compile @@ -1102,11 +1104,10 @@ Special variables are as noted in \"List of special variables\"." "Recompile %s? " "Already compiled %s.") filename) - (let - ((dest (byte-compile-dest-file full-path))) - (and - (file-exists-p dest) - (file-newer-than-file-p full-path dest))))))) + (not + (file-newer-than-file-p + full-path + (byte-compile-dest-file full-path))))))) (prog1 (list -- 2.11.4.GIT