From: Gabriel VLASIU <gabriel@vlasiu.net>
Date: Thu, 4 Apr 2013 15:43:30 +0000 (+0300)
Subject: wmbiff: Fix segfault when -display or -geometry argument is missing.
X-Git-Tag: wmix-3.2~37
X-Git-Url: https://repo.or.cz/w/dockapps.git/commitdiff_plain/8d972d5f4431f9fc4a585ff3e7a59438cca663fe

wmbiff: Fix segfault when -display or -geometry argument is missing.
---

diff --git a/wmbiff/wmgeneral/wmgeneral.c b/wmbiff/wmgeneral/wmgeneral.c
index cb0fd6d..dc06cb6 100644
--- a/wmbiff/wmgeneral/wmgeneral.c
+++ b/wmbiff/wmgeneral/wmgeneral.c
@@ -475,11 +475,11 @@ void openXwindow(int argc, const char *argv[],
 	}
 
 	for (i = 1; argv[i]; i++) {
-		if (!strcmp(argv[i], "-display")) {
+		if (!strcmp(argv[i], "-display") && i < argc - 1) {
 			display_name = argv[i + 1];
 			i++;
 		}
-		if (!strcmp(argv[i], "-geometry")) {
+		if (!strcmp(argv[i], "-geometry") && i < argc - 1) {
 			geometry = argv[i + 1];
 			i++;
 		}