From: Jeremy Maitin-Shepard <jeremy@jeremyms.com>
Date: Tue, 5 Feb 2013 06:46:47 +0000 (-0800)
Subject: hints: ensure that dead DOM objects don't prevent us from leaving a hints interaction
X-Git-Tag: debian-1.0--pre-1+git160130-1~184
X-Git-Url: https://repo.or.cz/w/conkeror.git/commitdiff_plain/040058dde0771747fd14b15795a44dfd7ff8349b

hints: ensure that dead DOM objects don't prevent us from leaving a hints interaction
---

diff --git a/modules/hints.js b/modules/hints.js
index 71c93f6..2d1d232 100644
--- a/modules/hints.js
+++ b/modules/hints.js
@@ -393,12 +393,19 @@ hint_manager.prototype = {
             if (h.visible) {
                 h.visible = false;
                 if (h.saved_color != null) {
-                    h.elem.style.color = h.saved_color;
-                    h.elem.style.backgroundColor = h.saved_bgcolor;
+                    try {
+                        h.elem.style.color = h.saved_color;
+                        h.elem.style.backgroundColor = h.saved_bgcolor;
+                    } catch (e) { /* element may be dead */ }
                 }
-                if (h.img_hint)
-                    h.img_hint.style.display = "none";
-                h.hint.style.display = "none";
+                if (h.img_hint) {
+                    try {
+                        h.img_hint.style.display = "none";
+                    } catch (e) { /* element may be dead */ }
+                }
+                try {
+                    h.hint.style.display = "none";
+                } catch (e) { /* element may be dead */ }
             }
         }
     },
@@ -406,12 +413,19 @@ hint_manager.prototype = {
     remove: function () {
         for (var i = 0, h; h = this.hints[i]; ++i) {
             if (h.visible && h.saved_color != null) {
-                h.elem.style.color = h.saved_color;
-                h.elem.style.backgroundColor = h.saved_bgcolor;
+                try {
+                    h.elem.style.color = h.saved_color;
+                    h.elem.style.backgroundColor = h.saved_bgcolor;
+                } catch (e) { /* element may be dead */ }
             }
-            if (h.img_hint)
-                h.img_hint.parentNode.removeChild(h.img_hint);
-            h.hint.parentNode.removeChild(h.hint);
+            if (h.img_hint) {
+                try {
+                    h.img_hint.parentNode.removeChild(h.img_hint);
+                } catch (e) { /* element may be dead */ }
+            }
+            try {
+                h.hint.parentNode.removeChild(h.hint);
+            } catch (e) { /* element may be dead */ }
         }
         this.hints = [];
         this.valid_hints = [];