From: Vitaly Mayatskikh <v.mayatskih@gmail.com>
Date: Sun, 24 Oct 2010 13:57:52 +0000 (+0200)
Subject: Remove uint32->int32 hack. Recent iolib handles mangled requests ok.
X-Git-Url: https://repo.or.cz/w/cl-v4l2.git/commitdiff_plain/201d9e5c0734d5b9ad4ccff6e1061cfa4b79b9f3

Remove uint32->int32 hack. Recent iolib handles mangled requests ok.
---

diff --git a/v4l2.lisp b/v4l2.lisp
index 9123dbc..1eca665 100644
--- a/v4l2.lisp
+++ b/v4l2.lisp
@@ -21,10 +21,14 @@
 
 ;; hack uint32->int32
 (defun ioctl (fd req arg)
-  (let ((req! (if (> req (ash 1 31))
-		  (- req (ash 1 32))
-		  req)))
-    (isys:ioctl fd req! arg)))
+  ;; CFFI grovels C constants as int64, and that mangles V4L2 ioctl requests.
+  ;; There was a need in a hack, which is commented out below. But current
+  ;; IOLIB (0.7.1) handles mangled requests ok.
+  ;;
+  ;; (let ((req! (if (> req (ash 1 31))
+  ;;                 (- req (ash 1 32))
+  ;;                 req)))
+    (isys:ioctl fd req arg))
 
 (defun query-capabilities (fd)
   "Query for device capabilities."