| commit | 12d6ce1dba504dfc5279b8d24da3edb4865c2820 | |
| author | Junio C Hamano <gitster@pobox.com> | |
| Mon, 24 Aug 2015 20:03:07 +0000 (24 13:03 -0700) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Mon, 24 Aug 2015 20:09:02 +0000 (24 13:09 -0700) | ||
| tree | b986a6e22bf290aa4f74d566169a6d54db6e4f3f | treesnapshot (tar.gz zip) |
| parent | 57c867efe4e005e40cfdee8a64550d7a95bbb9a0 | commitdiff |
write_file(): drop "fatal" parameter
All callers except three passed 1 for the "fatal" parameter to ask
this function to die upon error, but to a casual reader of the code,
it was not all obvious what that 1 meant. Instead, split the
function into two based on a common write_file_v() that takes the
flag, introduce write_file_gently() as a new way to attempt creating
a file without dying on error, and make three callers to call it.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
All callers except three passed 1 for the "fatal" parameter to ask
this function to die upon error, but to a casual reader of the code,
it was not all obvious what that 1 meant. Instead, split the
function into two based on a common write_file_v() that takes the
flag, introduce write_file_gently() as a new way to attempt creating
a file without dying on error, and make three callers to call it.
Signed-off-by: Junio C Hamano <gitster@pobox.com>