| commit | 115dedd72223e101181363f4e6053b4c937fdc37 | |
| author | Jeff King <peff@peff.net> | |
| Sun, 8 Sep 2013 09:02:06 +0000 (8 05:02 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Mon, 9 Sep 2013 18:15:17 +0000 (9 11:15 -0700) | ||
| tree | 75792b9c700829cda9241c48fa7bce64663d9ca3 | treesnapshot (tar.gz zip) |
| parent | 05e95155a10fab3d3c495076e51b2ce79fa26cf3 | commitdiff |
upload-pack: bump keepalive default to 5 seconds
There is no reason not to turn on keepalives by default.
They take very little bandwidth, and significantly less than
the progress reporting they are replacing. And in the case
that progress reporting is on, we should never need to send
a keepalive anyway, as we will constantly be showing
progress and resetting the keepalive timer.
We do not necessarily know what the client's idea of a
reasonable timeout is, so let's keep this on the low side of
5 seconds. That is high enough that we will always prefer
our normal 1-second progress reports to sending a keepalive
packet, but low enough that no sane client should consider
the connection hung.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
There is no reason not to turn on keepalives by default.
They take very little bandwidth, and significantly less than
the progress reporting they are replacing. And in the case
that progress reporting is on, we should never need to send
a keepalive anyway, as we will constantly be showing
progress and resetting the keepalive timer.
We do not necessarily know what the client's idea of a
reasonable timeout is, so let's keep this on the low side of
5 seconds. That is high enough that we will always prefer
our normal 1-second progress reports to sending a keepalive
packet, but low enough that no sane client should consider
the connection hung.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| Documentation/config.txt | diffblobblamehistory | |
| upload-pack.c | diffblobblamehistory |