Stefan Metzmacher [Wed, 17 Mar 2010 11:09:53 +0000 (17 12:09 +0100)]
s4:torture/rpc/samba3rpc.c: make use of dcerpc_binding_handle stubs
metze
Stefan Metzmacher [Wed, 17 Mar 2010 11:05:10 +0000 (17 12:05 +0100)]
s4:torture/rpc/samsync.c: make use of dcerpc_binding_handle stubs
metze
Stefan Metzmacher [Mon, 15 Mar 2010 08:01:17 +0000 (15 09:01 +0100)]
s4:torture/rpc/samr_accessmask.c: make use of dcerpc_binding_handle stubs
metze
Stefan Metzmacher [Wed, 17 Mar 2010 11:06:05 +0000 (17 12:06 +0100)]
s4:torture/rpc/dssetup.c: make use of dcerpc_binding_handle stubs
metze
Stefan Metzmacher [Wed, 17 Mar 2010 11:05:42 +0000 (17 12:05 +0100)]
s4:torture/rpc/bench.c: make use of dcerpc_binding_handle stubs
metze
Stefan Metzmacher [Tue, 16 Mar 2010 10:34:04 +0000 (16 11:34 +0100)]
s4:torture/rpc/samlogon.c: make use of dcerpc_binding_handle stubs
metze
Stefan Metzmacher [Tue, 16 Mar 2010 10:22:28 +0000 (16 11:22 +0100)]
s4:torture/rpc/netlogon.c: make use of dcerpc_binding_handle stubs
metze
Stefan Metzmacher [Tue, 16 Mar 2010 10:10:16 +0000 (16 11:10 +0100)]
s4:torture/rpc/schannel.c: make use of dcerpc_binding_handle stubs
metze
Stefan Metzmacher [Tue, 16 Mar 2010 09:55:41 +0000 (16 10:55 +0100)]
s4:torture/rpc/testjoin.c: make use of dcerpc_binding_handle stubs
metze
Stefan Metzmacher [Fri, 12 Mar 2010 16:51:06 +0000 (12 17:51 +0100)]
s4:torture/rpc/samr.c: make use of dcerpc_binding_handle stubs
metze
Stefan Metzmacher [Wed, 17 Mar 2010 13:00:45 +0000 (17 14:00 +0100)]
s4:librpc/rpc: initialize p->binding_handle in dcerpc_secondary_context()
metze
Günther Deschner [Wed, 17 Mar 2010 14:55:23 +0000 (17 15:55 +0100)]
s4-smbtorture: workaround broken REG_MULTI_SZ from winreg in s3
during SetPrinterDataEx SPOOLSS test.
Guenther
Günther Deschner [Wed, 17 Mar 2010 14:45:54 +0000 (17 15:45 +0100)]
s4-smbtorture: workaround the fact that you cannot fully rename a printer in samba.
Guenther
Günther Deschner [Wed, 17 Mar 2010 14:32:42 +0000 (17 15:32 +0100)]
s4-smbtorture: only use "friendly" data in extended SetPrinterDataEx test.
Passes against windows but not against samba yet :-(
Guenther
Günther Deschner [Wed, 17 Mar 2010 10:31:43 +0000 (17 11:31 +0100)]
s4-smbtorture: skip security descriptor tests against Samba in RPC-WINREG.
Guenther
Günther Deschner [Wed, 17 Mar 2010 00:25:42 +0000 (17 01:25 +0100)]
s4-smbtorture: re-arrange tests in RPC-WINREG.
Mostly choping test_Open() into smaller parts.
Guenther
Günther Deschner [Tue, 16 Mar 2010 23:57:22 +0000 (17 00:57 +0100)]
s4-smbtorture: add test to check different keytypes.
This test will be skipped for samba.
Guenther
Günther Deschner [Wed, 17 Mar 2010 10:36:09 +0000 (17 11:36 +0100)]
s4-smbtorture: add test_DeleteKey_opts to RPC-WINREG.
Guenther
Günther Deschner [Tue, 16 Mar 2010 23:55:41 +0000 (17 00:55 +0100)]
s4-smbtorture: add test_OpenKey_opts() to RPC-WINREG.
Guenther
Günther Deschner [Tue, 16 Mar 2010 23:53:21 +0000 (17 00:53 +0100)]
s4-smbtorture: add test_CreateKey_opts() to RPC-WINREG test.
Guenther
Günther Deschner [Tue, 16 Mar 2010 23:05:52 +0000 (17 00:05 +0100)]
s4-smbtorture: put HKLM current_version test into an own function.
Guenther
Günther Deschner [Tue, 16 Mar 2010 23:05:02 +0000 (17 00:05 +0100)]
s4-smbtorture: use binding handle for simple SetValue winreg test.
Guenther
Stefan Metzmacher [Thu, 11 Mar 2010 11:00:34 +0000 (11 12:00 +0100)]
s4:torture/rpc/lsa*: make use of dcerpc_binding_handle stubs
metze
Stefan Metzmacher [Tue, 16 Mar 2010 10:24:25 +0000 (16 11:24 +0100)]
s4:torture/rpc/remote_pac.c: make use of dcerpc_binding_handle stubs
metze
Günther Deschner [Tue, 16 Mar 2010 22:02:29 +0000 (16 23:02 +0100)]
s3-vfs: fix some buildwarnings in traffic analyzer, there are many more.
Holger, please check.
Guenther
Volker Lendecke [Tue, 16 Mar 2010 21:22:21 +0000 (16 22:22 +0100)]
s3: Make login_cache_write take a pointer
Volker Lendecke [Tue, 16 Mar 2010 21:18:52 +0000 (16 22:18 +0100)]
s3: Make login_cache_read take a pointer, avoid a malloc
Volker Lendecke [Tue, 16 Mar 2010 21:08:37 +0000 (16 22:08 +0100)]
s3: Remove a typedef
Volker Lendecke [Tue, 16 Mar 2010 21:23:06 +0000 (16 22:23 +0100)]
s3: Fix some nonempty blank lines
Günther Deschner [Tue, 16 Mar 2010 21:17:55 +0000 (16 22:17 +0100)]
s3: fix buildwarning in smbta-util.
Guenther
Günther Deschner [Tue, 16 Mar 2010 20:50:07 +0000 (16 21:50 +0100)]
s4-smbtorture: add lsa_SetTrustedDomainInfoByName NDR test.
Thanks Simo for providing the data and pointing out the IDL failure.
Guenther
Günther Deschner [Tue, 16 Mar 2010 20:15:50 +0000 (16 21:15 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Tue, 16 Mar 2010 20:14:45 +0000 (16 21:14 +0100)]
lsa: fix IDL for lsa_SetTrustedDomainInfoByName.
Guenther
Andreas Schneider [Tue, 16 Mar 2010 17:27:00 +0000 (16 13:27 -0400)]
Fix developer build, remove malloc
Matthias Dieter Wallnöfer [Tue, 16 Mar 2010 17:20:51 +0000 (16 18:20 +0100)]
kerberos - set the memory to "0"s before freeing the password to prevent security issues
Matthias Dieter Wallnöfer [Tue, 16 Mar 2010 16:07:04 +0000 (16 17:07 +0100)]
heimdal - remove unused variable
Matthias Dieter Wallnöfer [Tue, 16 Mar 2010 15:53:39 +0000 (16 16:53 +0100)]
heimdal - fix overlapped identifiers in the "krb5" library
Matthias Dieter Wallnöfer [Tue, 16 Mar 2010 15:26:25 +0000 (16 16:26 +0100)]
heimdal - free always "ctx->password" when it isn't needed anymore
"strdup" does always create a new object in the memory (through "malloc") which
needs to be freed if it isn't used anymore.
Matthias Dieter Wallnöfer [Tue, 16 Mar 2010 15:29:46 +0000 (16 16:29 +0100)]
s4:auth/kerberos/kerberos.c - fix also here a memory leak
The options need to be freed also on this error case.
Matthias Dieter Wallnöfer [Tue, 16 Mar 2010 15:23:57 +0000 (16 16:23 +0100)]
libcli/auth/schannel_state_tdb.c - fix a memory leak
Matthias Dieter Wallnöfer [Tue, 16 Mar 2010 15:00:34 +0000 (16 16:00 +0100)]
s4:wb_cmd_getgroups - fix failure in s4 winbind's "getgroups"
Günther Deschner [Tue, 16 Mar 2010 15:05:07 +0000 (16 16:05 +0100)]
s4-smbtorture: use random buffer for extended SetValue test in RPC-WINREG.
Guenther
Stefan Metzmacher [Mon, 15 Mar 2010 16:56:14 +0000 (15 17:56 +0100)]
s4:torture/rpc/winreg.c: make use of dcerpc_binding_handle stubs
metze
Stefan Metzmacher [Fri, 12 Mar 2010 10:09:00 +0000 (12 11:09 +0100)]
s4:torture/rpc/spoolss_win.c: make use of dcerpc_binding_handle stubs
metze
Stefan Metzmacher [Fri, 12 Mar 2010 09:53:54 +0000 (12 10:53 +0100)]
s4:torture/rpc/spoolss_notify.c: make use of dcerpc_binding_handle stubs
metze
Stefan Metzmacher [Fri, 12 Mar 2010 09:53:15 +0000 (12 10:53 +0100)]
s4:torture/rpc/spoolss_notify.c: fix compiler warnings
metze
Stefan Metzmacher [Tue, 16 Mar 2010 10:45:51 +0000 (16 11:45 +0100)]
s4:torture/rpc/spoolss.c: make use of dcerpc_binding_handle stubs
metze
Stefan Metzmacher [Tue, 16 Mar 2010 09:27:42 +0000 (16 10:27 +0100)]
s4:tortore/rpc/spoolss.c: fix compiler warning
metze
Stefan Metzmacher [Tue, 16 Mar 2010 09:55:12 +0000 (16 10:55 +0100)]
s4:torture/rpc/autoidl.c: make use of dcerpc_binding_handle stubs
metze
Stefan Metzmacher [Tue, 16 Mar 2010 09:43:39 +0000 (16 10:43 +0100)]
s4:torture/rpc/mgmt.c: make use of dcerpc_binding_handle stubs
metze
Stefan Metzmacher [Tue, 16 Mar 2010 09:42:58 +0000 (16 10:42 +0100)]
s4:torture/rpc/remact.c: make use of dcerpc_binding_handle stubs
metze
Stefan Metzmacher [Tue, 16 Mar 2010 09:36:19 +0000 (16 10:36 +0100)]
s4:torture/rpc/oxidresolve.c: make use of dcerpc_binding_handle stubs
metze
Stefan Metzmacher [Tue, 16 Mar 2010 09:32:56 +0000 (16 10:32 +0100)]
s4:torture/rpc/initshutdown.c: make use of dcerpc_binding_handle stubs
metze
Stefan Metzmacher [Mon, 15 Mar 2010 09:59:05 +0000 (15 10:59 +0100)]
s4:torture/rpc/epmapper.c: make use of dcerpc_binding_handle stubs
metze
Stefan Metzmacher [Mon, 15 Mar 2010 09:55:00 +0000 (15 10:55 +0100)]
s4:torture/rpc/eventlog.c: make use of dcerpc_binding_handle stubs
metze
Stefan Metzmacher [Mon, 15 Mar 2010 09:53:50 +0000 (15 10:53 +0100)]
s4:tortore/rpc/eventlog.c: rename variable 'b' => 'br'
metze
Stefan Metzmacher [Mon, 15 Mar 2010 09:50:12 +0000 (15 10:50 +0100)]
s4:torture/rpc/svcctl.c: make use of dcerpc_binding_handle stubs
metze
Stefan Metzmacher [Mon, 15 Mar 2010 09:49:02 +0000 (15 10:49 +0100)]
s4:torture/rpc/atsvc.c: make use of dcerpc_binding_handle stubs
metze
Stefan Metzmacher [Mon, 15 Mar 2010 09:19:02 +0000 (15 10:19 +0100)]
s4:torture/rpc/wkssvc.c: make use of dcerpc_binding_handle stubs
metze
Stefan Metzmacher [Mon, 15 Mar 2010 09:08:04 +0000 (15 10:08 +0100)]
s4:torture/rpc/srvsvc.c: make use of dcerpc_binding_handle stubs
metze
Stefan Metzmacher [Thu, 11 Mar 2010 12:03:26 +0000 (11 13:03 +0100)]
s4:torture/rpc/dsgetinfo.c: make use of dcerpc_binding_handle stubs
metze
Stefan Metzmacher [Thu, 11 Mar 2010 11:55:46 +0000 (11 12:55 +0100)]
s4:torture/rpc/dssync.c: make use of dcerpc_binding_handle stubs
metze
Stefan Metzmacher [Thu, 11 Mar 2010 11:55:24 +0000 (11 12:55 +0100)]
s4:torture/rpc/drsuapi*: make use of dcerpc_binding_handle stubs
metze
Stefan Metzmacher [Fri, 12 Mar 2010 10:25:01 +0000 (12 11:25 +0100)]
s4:torture/rpc/unixinfo.c: make use of dcerpc_binding_handle stubs
metze
Günther Deschner [Tue, 16 Mar 2010 14:30:13 +0000 (16 15:30 +0100)]
s4-smbtorture: remove NotifyChangeKeyValue s3 skip in RPC-WINREG:
Guenther
Günther Deschner [Tue, 16 Mar 2010 14:29:14 +0000 (16 15:29 +0100)]
s3-winreg: change notify call has no meaning when called remotely.
Just return not supported to make smbtorture happy.
Guenther
Günther Deschner [Tue, 16 Mar 2010 12:53:54 +0000 (16 13:53 +0100)]
s3-registry: make sure root has full registry access (in particular for make test).
Guenther
Günther Deschner [Tue, 16 Mar 2010 12:52:48 +0000 (16 13:52 +0100)]
s4-smbtorture: make it a bit easier to track failures in RPC-SPOOLSS-PRINTER.
Guenther
Simo Sorce [Fri, 26 Feb 2010 02:40:27 +0000 (25 21:40 -0500)]
s4:torture-ndr add lsarSetForestTrustInformation ndr test
Signed-off-by: Günther Deschner <gd@samba.org>
Günther Deschner [Tue, 16 Mar 2010 13:03:49 +0000 (16 14:03 +0100)]
s4-lsa: fix dcesrv_lsa_lsaRSetForestTrustInformation server stub.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Günther Deschner [Tue, 16 Mar 2010 13:03:35 +0000 (16 14:03 +0100)]
s3-lsa: fix _lsa_lsaRSetForestTrustInformation server stub.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Günther Deschner [Tue, 16 Mar 2010 13:01:27 +0000 (16 14:01 +0100)]
s3: re-run make samba3-idl.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Simo Sorce [Tue, 16 Mar 2010 12:59:32 +0000 (16 13:59 +0100)]
s4:idl add lsaRSetForestTrustInformation
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Tue, 16 Mar 2010 11:48:47 +0000 (16 12:48 +0100)]
Revert "Revert "s4-smbtorture: skip extended SetValue test against Samba (both dont survive).""
This reverts commit
508c218eb2f4bf8c45dc9d481576c87ed4fecbd3.
This lets make test fail.
Matthias: please make sure make test still passes when you change things like
this...(maybe add something to knownfail or so)
metze
Stefan Metzmacher [Tue, 16 Mar 2010 13:25:11 +0000 (16 14:25 +0100)]
s4:torture/rpc/dsgetinfo.c: fix name resolving for ldap_url
metze
Jim McDonough [Tue, 16 Mar 2010 14:04:51 +0000 (16 10:04 -0400)]
Update copyright
Matthias Dieter Wallnöfer [Tue, 16 Mar 2010 14:00:33 +0000 (16 15:00 +0100)]
security.idl - push generated code diff
Matthias Dieter Wallnöfer [Tue, 16 Mar 2010 13:07:51 +0000 (16 14:07 +0100)]
s4:resolve_oids LDB module - not really a change but a nicer method to call "talloc_reference"
Jim McDonough [Tue, 16 Mar 2010 13:58:34 +0000 (16 09:58 -0400)]
Don't exit(0) on error
Holger Hetterich [Mon, 15 Feb 2010 16:47:30 +0000 (15 17:47 +0100)]
s3: vfs_smb_traffic_analyzer.c: add VFS functions for file open and close
Holger Hetterich [Sun, 7 Feb 2010 19:39:58 +0000 (7 20:39 +0100)]
smb_traffic_analyzer.c: optimize marshalling function and document
Collect all data that is needed, and use only one talloc_asprintf
operation to create the string of common data. This simplifies
the code a bit and is most probably faster than the old method.
Also, #define SMBTA_COMMON_DATA_COUNT as a complete string,
speeding things up because we know the value at compile time.
Holger Hetterich [Sat, 6 Feb 2010 10:36:14 +0000 (6 11:36 +0100)]
vfs_smb_traffic_analyzer.c: added function
static char *smb_traffic_analyzer_anonymize
This takes a lot of code out of the main functions,
and makes it a bit simpler. Do the anonymization in a function.
Since we already anonymized the username we don't need to do
this a second time in the v2 marshalling function.
Holger Hetterich [Thu, 4 Feb 2010 21:03:53 +0000 (4 22:03 +0100)]
Simplify the code a bit by creating the functions:
smb_traffic_analyzer_encrypt - doing the encryption of a data block,
smb_traffic_analyzer_create_header - create the protocol header,
smb_traffic_analyzer_write_data - actually write the data to the
socket.
Holger Hetterich [Sat, 30 Jan 2010 16:43:50 +0000 (30 17:43 +0100)]
Update the manpage of vfs_smb_traffic_analyzer and add smbta-util.
Holger Hetterich [Tue, 2 Feb 2010 19:04:40 +0000 (2 20:04 +0100)]
Add the number of common data blocks to the protocol.
Always send the number of common data blocks first. This way, we
can make the protocol backwards compatible. A receiver running with
an older subprotocol can just ignore if a newer sender sends more
common data.
Add a few remarks to the marshalling function. Add two #define lines
defining the protocol subrelease number and the number of common
data blocks to the header file.
Holger Hetterich [Tue, 2 Feb 2010 18:36:23 +0000 (2 19:36 +0100)]
Put all the protocol stuff into a separate header file.
All the structures and the vfs function identifier list is required
by the receiver. It's therefore very handy to have this in an extra
header file.
Holger Hetterich [Mon, 1 Feb 2010 23:14:28 +0000 (2 00:14 +0100)]
Add smbta-util to manage the encryption key.
This program allows the administrator to enable or disable AES
encryption when using vfs_smb_traffic_analyzer. It also generates new
keys, stores them to a file, so that the file can be reused on another
client or server.
Holger Hetterich [Fri, 29 Jan 2010 20:34:27 +0000 (29 21:34 +0100)]
Implement AES encryption of the data block.
First try. This runs on 16 bytes long AES block size, and enlarges the
data block with 16 bytes, to make sure all bytes are in. The added
bytes are filled with '.'. It then creates a header featuring the new
length to be send, and finally sends the data block, then returns.
This code is untested, as creating the receiver will be my next step.
To simplify traffic_analyzer's code, this code should run as a function.
It's on the do-to-list.
Holger Hetterich [Fri, 29 Jan 2010 13:57:20 +0000 (29 14:57 +0100)]
Implement anonymization for protocol v2.
Since we need to care for the SID too, do the anonymization in the
marshalling function and anonymize both the username and the SID.
Remove the 'A' status flag from the header definition. A listener
could see from the unencrypted header if the module is anonymizing
or not, which is certainly not wanted.
Holger Hetterich [Sat, 23 Jan 2010 21:45:28 +0000 (23 22:45 +0100)]
Make all remarks compatible to the linux kernel coding styleguide.
Holger Hetterich [Sat, 23 Jan 2010 21:03:22 +0000 (23 22:03 +0100)]
Added an exact description of the V2 protocol.
I don't think it should have it's place the man page, because this is
developer information.
Holger Hetterich [Fri, 22 Jan 2010 20:17:53 +0000 (22 21:17 +0100)]
Move the creation of the header.
Since the header block of the protocol contains the number of bytes to
come, we always send the header itself unmodified.
If we compress or crypt the data we are about to send, the length of the
data to send may change. Therefore, we no longer create the header in
smb_traffic_analyzer_create_string, but shortly before we send the data.
For both cases, encryption and normal, we create our own header, and
send it before the actual data.
In case of protocol v1, we don't need to create an extra header.
Just send the data, and return from the function.
Change a debug message to say that the header for crypted data has
been created.
Add a status flags consisting of 6 bytes to the header. Their function
will be descriped in one of the next patches, which is descriping
the header in a longer comment.
When anonymization and/or encryption is used, set the flags accordingly.
Holger Hetterich [Fri, 22 Jan 2010 13:55:33 +0000 (22 14:55 +0100)]
Fetch the SID of the user we are running as and send with the common
data.
Holger Hetterich [Fri, 22 Jan 2010 12:04:21 +0000 (22 13:04 +0100)]
Additionally send the vfs function id with the protocol.
Holger Hetterich [Thu, 21 Jan 2010 22:26:54 +0000 (21 23:26 +0100)]
According to the linux kernel coding styleguide, it's better to
align the switch and it's case statements in the same column.
This saves us one indentation level.
Holger Hetterich [Thu, 21 Jan 2010 22:16:58 +0000 (21 23:16 +0100)]
Don't use typedefs on the VFS function data structures as
typedefs are evil according to the linux kernel coding
styleguide.
Holger Hetterich [Thu, 21 Jan 2010 21:31:09 +0000 (21 22:31 +0100)]
Add read,pread,write,pwrite support to the V2 protocol.
Holger Hetterich [Mon, 14 Dec 2009 19:43:15 +0000 (14 20:43 +0100)]
Enable AES encryption of the data if a key was found in secrets.tdb.
Holger Hetterich [Fri, 11 Dec 2009 20:04:46 +0000 (11 21:04 +0100)]
Add rmdir, chdir, and rename as supported VFS functions
Holger Hetterich [Tue, 22 Sep 2009 18:01:35 +0000 (22 20:01 +0200)]
The format of data we are sending over the network will be flexible when sending over the network in protocol v2. To be able to do this, we create a new va-list function that is creating the buffer to send. Also it makes it easier for the receiver to parse the data; it sends an initial header containing the full length of the buffer to be send. For the individual strings, it sends sub headers containing the length of the upcoming substring to be send. With the header-data-header-data [..] structure we don't need to quote the sub strings finally enabling having all possible character sets in filenames etc..
In the sending function, implement mkdir to actually send it's data
for testing.