Günther Deschner [Mon, 7 Jun 2010 10:55:43 +0000 (7 12:55 +0200)]
s3-lsa: Fix static list of luids in our privileges implementation.
The high/low order changed while moving to LSA defines. Found by torture test.
Guenther
Günther Deschner [Mon, 7 Jun 2010 10:41:39 +0000 (7 12:41 +0200)]
s4-smbtorture: test workstation auth as well in RPC-SPOOLSS-ACCESS.
Guenther
Matthieu Patou [Fri, 7 May 2010 00:15:28 +0000 (7 04:15 +0400)]
s4:ldb python bindings - implement comparison on Python LDB Message objects
Coauthors: Jelmer Vernooij, Matthias Dieter Wallnöfer
Matthieu Patou [Sat, 5 Jun 2010 15:25:18 +0000 (5 19:25 +0400)]
s4: Remove an uselessly exposed control
Günther Deschner [Mon, 7 Jun 2010 09:21:26 +0000 (7 11:21 +0200)]
s4-smbtorture: handle printservers w/o printers in RPC-SPOOLSS-ACCESS.
Guenther
Günther Deschner [Sat, 5 Jun 2010 00:39:11 +0000 (5 02:39 +0200)]
s3-privileges: use LUID defines from lsa IDL.
Guenther
Matthew McGillis [Sat, 5 Jun 2010 00:48:40 +0000 (4 17:48 -0700)]
Fix bug with incorrect flag values for inherited ace in some cases.
Matthias Dieter Wallnöfer [Thu, 3 Jun 2010 16:35:00 +0000 (3 18:35 +0200)]
s4:password_hash LDB module - adapt the module to the new "ldb_msg_remove_attr" behaviour
Matthias Dieter Wallnöfer [Thu, 3 Jun 2010 16:22:10 +0000 (3 18:22 +0200)]
ldb:ldb_msg_remove_attr - provide a better implementation
We can have some special (bad) messages which contain multiple message elements
for the same attribute. The AD password change ones are such an example.
Matthias Dieter Wallnöfer [Sun, 6 Jun 2010 17:12:48 +0000 (6 19:12 +0200)]
s4:samldb LDB module - this codepart isn't needed due to the objectclass LDB module
When a "computer" entry will be added, also the inherited "user" objectclass is
going to be specified.
Matthias Dieter Wallnöfer [Fri, 4 Jun 2010 19:10:41 +0000 (4 21:10 +0200)]
s4:get_last_structural_class - only real structural classes can be candidates for fetching the last one
Classes with objectCategory = 1 are always structural, these with
objectCategory = 0 also (as we can see in our Windows 2008 R2 schema file where
class "Person" has 0 but is structural).
Abstract classes and auxiliary ones cannot be considered (objectCategory = 2, 3)
http://msdn.microsoft.com/en-us/library/ms677964(VS.85).aspx
Matthias Dieter Wallnöfer [Thu, 3 Jun 2010 16:05:52 +0000 (3 18:05 +0200)]
s4:ldap.py - enhance the RDN name test to show that invalid "name" attributes are allowed on add operations
Matthias Dieter Wallnöfer [Thu, 3 Jun 2010 16:25:43 +0000 (3 18:25 +0200)]
s4:rdn_name LDB module - use "ldb_msg_remove_attr" for deleting attributes
Matthias Dieter Wallnöfer [Thu, 3 Jun 2010 15:56:09 +0000 (3 17:56 +0200)]
s4:rdn_name LDB module - remove "rdn_name_find_attribute"
It does exactly the same as "ldb_msg_find_element".
Matthias Dieter Wallnöfer [Mon, 31 May 2010 12:52:46 +0000 (31 14:52 +0200)]
s4:dsdb/common/util.c - provide a better implementation of the "samdb_msg_add_(add/del)val" calls
This supports now also coexisting add and delete message elements with the
same attribute name.
Matthias Dieter Wallnöfer [Thu, 3 Jun 2010 16:37:15 +0000 (3 18:37 +0200)]
ldb:ltdb_filter_attrs - fix a counter variable type
Matthias Dieter Wallnöfer [Sat, 5 Jun 2010 12:33:52 +0000 (5 14:33 +0200)]
s4:ldap_server/ldap_backend.c - send back also the extended error message if it exists
This message often contains suggestions how to fix issues.
Matthias Dieter Wallnöfer [Sat, 5 Jun 2010 15:45:51 +0000 (5 17:45 +0200)]
s4:ridalloc LDB module - add more "talloc_free"s where useful
Some were missing on failure return branches.
Matthias Dieter Wallnöfer [Sat, 5 Jun 2010 18:08:45 +0000 (5 20:08 +0200)]
s4:acl LDB module - fix counter types where appropriate
Matthias Dieter Wallnöfer [Sat, 5 Jun 2010 17:58:28 +0000 (5 19:58 +0200)]
s4:descriptor LDB module - cosmetic fixup
Matthias Dieter Wallnöfer [Sun, 6 Jun 2010 18:23:42 +0000 (6 20:23 +0200)]
s4:urgent_replication.py - specify the "dnsRoot" attribute which is requested on "crossRef" entries
Matthias Dieter Wallnöfer [Sat, 5 Jun 2010 20:19:58 +0000 (5 22:19 +0200)]
s4:ldap.py - make sure that also the "posixuser" will be deleted on test breakages
Matthias Dieter Wallnöfer [Sat, 5 Jun 2010 22:11:16 +0000 (6 00:11 +0200)]
s4:provision - fix typo in substitution variable
Jeremy Allison [Sat, 5 Jun 2010 04:00:24 +0000 (4 21:00 -0700)]
Fix a long-standing bug with async io that would only be triggered by SMB2.
On normal or shutdown close, ensure we wait for any pending IO to
complete before returning. Implement a blocking aio_suspend inside
vfs_aio_fork.c. These changes pass make test when the aio_fork module
is used by default on the test shares.
Jeremy.
Björn Jacke [Sat, 5 Jun 2010 00:13:21 +0000 (5 02:13 +0200)]
s3:build: add shared lib flag for HP-UX compiler
Björn Jacke [Sat, 5 Jun 2010 00:12:02 +0000 (5 02:12 +0200)]
s3: fix build on Heimdal based systems like NetBSD5
Günther Deschner [Fri, 4 Jun 2010 23:26:49 +0000 (5 01:26 +0200)]
s4-smbtorture: make RPC-SPOOLSS-ACCESS more compatible with older samba releases.
Guenther
Günther Deschner [Fri, 4 Jun 2010 23:25:05 +0000 (5 01:25 +0200)]
s4-smbtorture: remove another incarnation of test_ClosePrinter.
This should fix the build; why waf didn't catch that durint make bin/smbtorture4 ?
Guenther
Günther Deschner [Fri, 4 Jun 2010 17:03:11 +0000 (4 19:03 +0200)]
s4-smbtorture: add RPC-SPOOLSS-ACCESS.
This test creates
- a user
- a user with BUILTIN\Administrators membership
- a user with BUILTIN\Print Operators membership
- a user with SePrintOperatorPrivilege (if available)
- a user with full access in security descriptor
and checks what access rights are granted in spoolss_OpenPrinterEx.
Guenther
Günther Deschner [Fri, 4 Jun 2010 17:02:17 +0000 (4 19:02 +0200)]
s4-smbtorture: share test_ClosePrinter between RPC-SPOOLSS and RPC-SPOOLSS-WIN.
Guenther
Günther Deschner [Fri, 4 Jun 2010 14:55:07 +0000 (4 16:55 +0200)]
s3-rpcclient: allow to add access_mask in cmd_spoolss_open_printer_ex().
Guenther
Günther Deschner [Fri, 4 Jun 2010 17:05:24 +0000 (4 19:05 +0200)]
s4-smbtorture: check error codes in RAP-SAM testsuite.
Guenther
Jeremy Allison [Fri, 4 Jun 2010 20:49:38 +0000 (4 13:49 -0700)]
Oops. Forgot to re-initialize the aio_ex pointer from sival_ptr.
Jeremy Allison [Fri, 4 Jun 2010 18:41:57 +0000 (4 11:41 -0700)]
wait_for_aio_completion() should return 0 on non-aio compiled case.
Jeremy Allison [Fri, 4 Jun 2010 18:41:38 +0000 (4 11:41 -0700)]
Rename req -> smbreq.
Jeremy Allison [Fri, 4 Jun 2010 18:30:46 +0000 (4 11:30 -0700)]
Change smbd_aio_complete_mid() -> smbd_aio_complete_aio_ex(). Simplifies
the code and eliminates find_aio_ex().
Jeremy.
Andreas Schneider [Thu, 3 Jun 2010 20:04:08 +0000 (3 22:04 +0200)]
s3-rpc: Create a file with all functions for a internal named pipe.
This makes it possible to use the samr rpc server in winbind without
linking in smbd.
Reviewed-by: Simo Sorce <idra@samba.org>
Andreas Schneider [Thu, 3 Jun 2010 20:01:46 +0000 (3 22:01 +0200)]
s3-rpc: Seperate rpc_srv_register for plain connection.
This will make it possible to create plain rpc named pipe connnections.
Reviewed-by: Simo Sorce <idra@samba.org>
Andreas Schneider [Wed, 2 Jun 2010 17:39:18 +0000 (2 19:39 +0200)]
s3-auth: Moved smbd user functions to a generic place.
Reviewed-by: Simo Sorce <idra@samba.org>
Andreas Schneider [Mon, 31 May 2010 16:33:38 +0000 (31 18:33 +0200)]
s3-smbd: Remove unneeded dependency of map_username to globals.c.
Reviewed-by: Simo Sorce <idra@samba.org>
Günther Deschner [Fri, 4 Jun 2010 12:31:08 +0000 (4 14:31 +0200)]
s3-selftest: do not call main RPC-SPOOLSS testsuite.
The tests formerly available in there can now be accessed via
RPC-SPOOLSS-PRINTSERVER.
Guenther
Günther Deschner [Thu, 3 Jun 2010 19:39:51 +0000 (3 21:39 +0200)]
s4-smbtorture: completely rework RPC-SPOOLSS-PRINTER.
This is now a child testsuite to RPC-SPOOLSS. You can call simple tests via
RPC-SPOOLSS-{addprinter,addprinterex}-testname.
Guenther
Günther Deschner [Thu, 3 Jun 2010 18:48:49 +0000 (3 20:48 +0200)]
s4-smbtorture: rework order of test in RPC-SPOOLSS-PRINTSERVER a bit.
Guenther
Björn Jacke [Thu, 3 Jun 2010 22:55:10 +0000 (4 00:55 +0200)]
ѕ3:Makefile: use PIC instead of PIE flags for shared libs
otherwise shared lib builds are broken on some platforms
Jeremy Allison [Thu, 3 Jun 2010 18:50:08 +0000 (3 11:50 -0700)]
Allow us to cope correctly with NT_STATUS_MORE_PROCESSING_REQUIRED when downgrading from krb5 to NTLMSSP over SMB2.
Jeremy.
Jeremy Allison [Thu, 3 Jun 2010 18:18:11 +0000 (3 11:18 -0700)]
Found by Guenther - fix up our fallback paths from krb5 to NTLMSSP when using SMB2.
Jeremy.
Günther Deschner [Tue, 18 May 2010 21:40:43 +0000 (18 23:40 +0200)]
s4-smbtorture: convert RPC-SPOOLSS into a torture suite.
Guenther
Günther Deschner [Thu, 3 Jun 2010 15:08:55 +0000 (3 17:08 +0200)]
s4-smbtorture: allow to call single tests from a testcase in a testsuite
directly on the commandline.
Guenther
James Peach [Fri, 19 Mar 2010 02:30:54 +0000 (18 19:30 -0700)]
libreplace: Fix readline build with libedit.
libedit on MAc OSX 10.5 does not have the rl_completion_t typedef,
but uses a internal typedef names CPPFunction.
Signed-off-by: Günther Deschner <gd@samba.org>
Günther Deschner [Thu, 3 Jun 2010 14:30:55 +0000 (3 16:30 +0200)]
s3-spoolss: add and use spoolss_printerinfo2_to_setprinterinfo2().
This fixes some invalid typecasts.
Guenther
Volker Lendecke [Thu, 3 Jun 2010 14:09:31 +0000 (3 16:09 +0200)]
s3: Fix the build of the nfsv4 acl code
Günther Deschner [Thu, 3 Jun 2010 12:54:02 +0000 (3 14:54 +0200)]
s4-smbtorture: move PrintProcessors winreg test to main RPC-SPOOLSS test.
Guenther
Günther Deschner [Thu, 3 Jun 2010 11:01:40 +0000 (3 13:01 +0200)]
s4-smbtorture: add test_PrintProcessors_winreg.
This does cross reference checks between spoolss PrintProcessors and entries
stored in winreg.
Guenther
Günther Deschner [Thu, 3 Jun 2010 11:01:16 +0000 (3 13:01 +0200)]
s4-smbtorture: refactor test_EnumPrintProcessors().
Guenther
Günther Deschner [Thu, 3 Jun 2010 09:46:44 +0000 (3 11:46 +0200)]
s4-smbtorture: only test data up to a length of 9 bytes in test_SetPrinterDataEx_matrix().
Guenther
Günther Deschner [Wed, 2 Jun 2010 23:45:01 +0000 (3 01:45 +0200)]
s3: remove authdata.h
Guenther
Günther Deschner [Thu, 3 Jun 2010 08:25:32 +0000 (3 10:25 +0200)]
s3-build: pure cosmetics, use better names for gen_ndr code pieces.
Guenther
Günther Deschner [Thu, 3 Jun 2010 07:57:50 +0000 (3 09:57 +0200)]
s3-build: only include generated spoolss headers (not ndr headers).
Guenther
Günther Deschner [Thu, 3 Jun 2010 08:49:34 +0000 (3 10:49 +0200)]
s3: remove rpc_secdes.h completely.
Guenther
Günther Deschner [Thu, 3 Jun 2010 08:36:05 +0000 (3 10:36 +0200)]
s3-security: use shared "Standard access rights.".
Guenther
Günther Deschner [Wed, 2 Jun 2010 23:27:50 +0000 (3 01:27 +0200)]
security: move generic_mapping and standard_mapping to security.idl.
Guenther
Günther Deschner [Wed, 2 Jun 2010 21:57:09 +0000 (2 23:57 +0200)]
s3-security: use shared "File Object specific access rights".
Guenther
Günther Deschner [Wed, 2 Jun 2010 21:48:15 +0000 (2 23:48 +0200)]
s3-security: use shared "Generic access rights".
Guenther
Günther Deschner [Wed, 2 Jun 2010 21:45:44 +0000 (2 23:45 +0200)]
s3-security: use shared Security Access Masks Rights.
Guenther
Günther Deschner [Wed, 2 Jun 2010 21:45:14 +0000 (2 23:45 +0200)]
s3-security: move ALL_SECURITY_INFORMATION to the only user.
Guenther
Günther Deschner [Wed, 2 Jun 2010 21:39:05 +0000 (2 23:39 +0200)]
s3-security: remove duplicate Extra W2K flags.
Guenther
Günther Deschner [Wed, 2 Jun 2010 21:35:44 +0000 (2 23:35 +0200)]
s3-security: use shared SECINFO_DACL define.
Guenther
Günther Deschner [Wed, 2 Jun 2010 21:29:16 +0000 (2 23:29 +0200)]
s3-security: use shared SECINFO_SACL define.
Guenther
Günther Deschner [Wed, 2 Jun 2010 21:25:18 +0000 (2 23:25 +0200)]
s3-security: use shared SECINFO_GROUP define.
Guenther
Günther Deschner [Wed, 2 Jun 2010 21:22:12 +0000 (2 23:22 +0200)]
s3-security: use shared SECINFO_OWNER define.
Guenther
Günther Deschner [Wed, 2 Jun 2010 21:16:32 +0000 (2 23:16 +0200)]
s3-security: remove some more shared secdesc defines.
Guenther
Jeremy Allison [Wed, 2 Jun 2010 23:57:08 +0000 (2 16:57 -0700)]
Ensure we remove SMB2 cancel requests from the active queue
now we don't remove them in the talloc destructor.
Jeremy.
Jeremy Allison [Wed, 2 Jun 2010 23:43:31 +0000 (2 16:43 -0700)]
Fix a crash bug found by Ira Cooper <samba@ira.wakeful.net>.
A create call comes in, goes async (on the oplock request).
At a later time (just before a cancel request is received)
it completes, and goes through smbd_smb2_request_reply() to
send the reply to the create call.
However, the output socket queue is full, so when
tstream_writev_queue_send() is called from smbd_smb2_request_reply(),
the smb2req stays on the "being processed" queue on
sconn->smb2.requests, as only when tstream_writev_queue_send() completes
is smbd_smb2_request_writev_done() get called, which will TALLOC_FREE
the smb2req (and thus take if off the queue).
The cancel comes in, gets processed and looks through the
requests on the queue, and BANG - hits the smb2req that
has already been processed and is outgoing....
Remove the request from the queue once
tstream_writev_queue_send() is called and not in the talloc
destructor function.
Jeremy.
Günther Deschner [Wed, 2 Jun 2010 22:09:26 +0000 (3 00:09 +0200)]
s3: remove unused librpc/ndr/sid.c.
Guenther
Jeremy Allison [Wed, 2 Jun 2010 17:25:56 +0000 (2 10:25 -0700)]
Move to using a DATA_BLOB inside of struct aio_extra, not a char *.
Will make using AIO in SMB2 easier.
Jeremy.
Günther Deschner [Wed, 2 Jun 2010 13:35:33 +0000 (2 15:35 +0200)]
s3-selftest: Fix blackbox smbclient s3 tests during make selftest.
Guenther
Matthieu Patou [Fri, 21 May 2010 07:57:29 +0000 (21 11:57 +0400)]
s3: Allow previous password to be stored and use it to check tickets
This patch is to fix bug 7099. It stores the current password in the
previous password key when the password is changed. It also check the
user ticket against previous password.
Signed-off-by: Günther Deschner <gd@samba.org>
Volker Lendecke [Tue, 5 Jan 2010 09:42:38 +0000 (5 10:42 +0100)]
s3: Add vfs_linux_xfs_sgid
http://oss.sgi.com/bugzilla/show_bug.cgi?id=280 shows an old Linux XFS bug that
still exists: Under certain circumstances the SGID bit is not inherited.
Kai Blin [Wed, 2 Jun 2010 09:28:54 +0000 (2 11:28 +0200)]
s3-waf: Fix up smbclient dependencies
Kai Blin [Wed, 2 Jun 2010 09:21:18 +0000 (2 11:21 +0200)]
s3-waf: Fixed dependencies of the the krbclient subsystem.
Andreas Schneider [Wed, 2 Jun 2010 09:19:36 +0000 (2 11:19 +0200)]
s3-waf: Fixed dependencies of the the avahi subsystem.
Matthias Dieter Wallnöfer [Wed, 2 Jun 2010 07:30:54 +0000 (2 09:30 +0200)]
s4:ldb_msg_element_compare - fix typo in comment
Matthias Dieter Wallnöfer [Tue, 1 Jun 2010 17:59:56 +0000 (1 19:59 +0200)]
s4:lib/ldb/pyldb_util.c - add a cast to quiet a warning
Jelmer, please fix if it isn't correct.
Ira Cooper [Wed, 2 Jun 2010 00:09:29 +0000 (1 17:09 -0700)]
SMB2: Fix rename on Windows 7.
This removes some code Jeremy (jra) suspected was bad. It turns out that the
command window rename command will not work with the offending code in place.
With it removed the bug is gone, and rename works.
Jeremy Allison [Tue, 1 Jun 2010 23:05:44 +0000 (1 16:05 -0700)]
Don't use sigev_value.sival_int to just store the mid, use sigev_value.sival_ptr to store the private data structure.
This allows easier use from SMB2. Ensure aio is initialized before the
aio_pending_size check else aio will never be used.
Jeremy.
Günther Deschner [Tue, 1 Jun 2010 21:02:13 +0000 (1 23:02 +0200)]
s3-eventlog: try to pass RPC-EVENTLOG during make test as non-root.
Guenther
Holger Hetterich [Sun, 30 May 2010 16:52:17 +0000 (30 18:52 +0200)]
s3-vfs: Send the share name instead of the path in smb_traffic_analyzer.
In protocol v2, the name of the service should be sent instead of the
path.
Signed-off-by: Andreas Schneider <asn@samba.org>
Günther Deschner [Tue, 1 Jun 2010 14:48:51 +0000 (1 16:48 +0200)]
s4-smbtorture: skip driverName and printerName DsSpooler tests for now.
Guenther
Günther Deschner [Tue, 1 Jun 2010 14:46:37 +0000 (1 16:46 +0200)]
s4-smbtorture: Make sure RPC-SPOOLSS and RPC-SPOOLSS-PRINTER pass against s3.
Printjobs are extremely fragile beasts on paused virtual printers within make
test. Very often the printq updater in the background is not fast enough, so
subsequent tests don't get to the updated information. Something to remember and
to work on later...
Guenther
Günther Deschner [Tue, 1 Jun 2010 14:04:19 +0000 (1 16:04 +0200)]
lib/replace: fix some c++ build warnings in testsuite.
Guenther
Anatoliy Atanasov [Tue, 1 Jun 2010 12:05:02 +0000 (1 15:05 +0300)]
s4: check the sacl and dacl pointers on the old sd
Kai Blin [Tue, 1 Jun 2010 13:37:40 +0000 (1 15:37 +0200)]
s3-waf: Fix the build
Michael Adam [Tue, 1 Jun 2010 13:31:17 +0000 (1 15:31 +0200)]
s3: remove unused prototype for lp_idmap_domains().
Kai Blin [Tue, 1 Jun 2010 08:31:11 +0000 (1 10:31 +0200)]
s3-waf: Add check for dirent.d_off member
Stefan Metzmacher [Mon, 31 May 2010 08:57:52 +0000 (31 10:57 +0200)]
s3:winbindd: make sure we only call static_init_idmap once
metze
Signed-off-by: Michael Adam <obnox@samba.org>
Andrew Bartlett [Mon, 24 May 2010 04:55:17 +0000 (24 14:55 +1000)]
s3:winbind Ensure we always init idmap_passdb before we use it
It seems that it is possible for idmap_init_passdb_domain() to be run
before idmap_init_domain(), so ensure we run the static init functions
in both.
Andrew Bartlett
Signed-off-by: Michael Adam <obnox@samba.org>
Andrew Bartlett [Mon, 24 May 2010 00:51:10 +0000 (24 10:51 +1000)]
s3:idmap Use idmap.idl defined structures and constants
This allows these structures to be shared across all of Samba
The additional name type ID_TYPE_BOTH is unused in source3 code at
this time.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Karolin Seeger [Tue, 1 Jun 2010 08:02:14 +0000 (1 10:02 +0200)]
s4-configure: Fix typo in comment.
Karolin
Karolin Seeger [Tue, 1 Jun 2010 07:45:19 +0000 (1 09:45 +0200)]
selftest: Fix typo in comment.
Karolin
Karolin Seeger [Tue, 1 Jun 2010 07:35:53 +0000 (1 09:35 +0200)]
s4-heimdal: Fix typo in comment.
Karolin