Samba/bjacke.git
10 years agolibrpc: Shorten dcerpc_binding_handle_call a bitmaster
Volker Lendecke [Thu, 6 Jun 2013 09:37:59 +0000 (6 11:37 +0200)]
librpc: Shorten dcerpc_binding_handle_call a bit

... saves 200 bytes on 64 bit Linux with -O3

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Jun 14 22:27:43 CEST 2013 on sn-devel-104

10 years agolibrpc: Use tevent_req_poll_ntstatus
Volker Lendecke [Thu, 6 Jun 2013 09:31:37 +0000 (6 11:31 +0200)]
librpc: Use tevent_req_poll_ntstatus

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agolibsmbclient: Fix typos
Volker Lendecke [Thu, 16 May 2013 08:26:09 +0000 (16 10:26 +0200)]
libsmbclient: Fix typos

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agotsocket: Add some const
Volker Lendecke [Tue, 11 Jun 2013 17:36:09 +0000 (11 19:36 +0200)]
tsocket: Add some const

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agogencache: Simplify gencache_init a bit
Volker Lendecke [Tue, 11 Jun 2013 19:03:22 +0000 (11 21:03 +0200)]
gencache: Simplify gencache_init a bit

Use the implicit cleanup facility CLEAR_IF_FIRST provides

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agogenrand: Slightly simplify do_reseed
Volker Lendecke [Thu, 13 Jun 2013 19:55:43 +0000 (13 21:55 +0200)]
genrand: Slightly simplify do_reseed

The only caller set "use_fd" to "true".

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Jun 14 20:29:56 CEST 2013 on sn-devel-104

10 years agotevent: Fix Coverity ID 989236 Operands don't affect result
Volker Lendecke [Thu, 13 Jun 2013 18:35:32 +0000 (13 20:35 +0200)]
tevent: Fix Coverity ID 989236 Operands don't affect result

"unsigned" could be less than uint64_t, so idx==UINT64_MAX is always false.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agodsdb: remove a wrong comment in dsdb_check_access_on_dn_internal()
Stefan Metzmacher [Thu, 13 Jun 2013 12:16:43 +0000 (13 14:16 +0200)]
dsdb: remove a wrong comment in dsdb_check_access_on_dn_internal()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu Jun 13 18:19:24 CEST 2013 on sn-devel-104

10 years agodsdb: don't allow a missing nTSecurityDescriptor in dsdb_get_sd_from_ldb_message()
Stefan Metzmacher [Thu, 13 Jun 2013 12:13:26 +0000 (13 14:13 +0200)]
dsdb: don't allow a missing nTSecurityDescriptor in dsdb_get_sd_from_ldb_message()

Every object has a nTSecurityDescriptor attribute.

This also avoids potential segfaults in the callers.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agodsdb: use AS_SYSTEM | SHOW_RECYCLED for access check searches
Stefan Metzmacher [Mon, 10 Jun 2013 11:31:59 +0000 (10 13:31 +0200)]
dsdb: use AS_SYSTEM | SHOW_RECYCLED for access check searches

We need AS_SYSTEM in order to get the nTSecurityDescriptor attribute.
Also the result of this search not controlled by the client
nor is the result exposed to the client.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agos4:smb_server: call irpc_add_name() at startup (bug #9905)
Stefan Metzmacher [Mon, 27 May 2013 10:10:57 +0000 (27 12:10 +0200)]
s4:smb_server: call irpc_add_name() at startup (bug #9905)

We should call irpc_add_name() when we start the smb_server task.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agos4:rpc_server: call irpc_add_name() at startup (bug #9905)
Stefan Metzmacher [Mon, 27 May 2013 10:10:57 +0000 (27 12:10 +0200)]
s4:rpc_server: call irpc_add_name() at startup (bug #9905)

We should call irpc_add_name() when we start the rpc_server task.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agos4:ldap_server: call irpc_add_name() at startup (bug #9905)
Stefan Metzmacher [Mon, 27 May 2013 10:10:57 +0000 (27 12:10 +0200)]
s4:ldap_server: call irpc_add_name() at startup (bug #9905)

We should call irpc_add_name() when we start the ldap_server task.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agodsdb repl_meta_data: Use dsdb_request_add_controls()
Andrew Bartlett [Fri, 31 May 2013 05:36:34 +0000 (31 15:36 +1000)]
dsdb repl_meta_data: Use dsdb_request_add_controls()

This makes the code easier to read.

Andrew Bartlett

Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu Jun 13 11:15:01 CEST 2013 on sn-devel-104

10 years agoInitialize the file descriptor in the files_struct before trying to close it. Otherwi...
Christof Schmitt [Wed, 12 Jun 2013 21:49:53 +0000 (12 14:49 -0700)]
Initialize the file descriptor in the files_struct before trying to close it. Otherwise, if one of the SETXATTR calls had failed, the close() call will return EBADF.

Signed-off-by: Christof Schmitt <christof.schmitt@us.ibm.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Richard Sharpe <rsharpe@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Jun 13 01:43:18 CEST 2013 on sn-devel-104

10 years agotevent: Link the tutorial on the mainpage.
Andreas Schneider [Wed, 12 Jun 2013 11:55:13 +0000 (12 13:55 +0200)]
tevent: Link the tutorial on the mainpage.

Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Jun 12 19:54:30 CEST 2013 on sn-devel-104

10 years agotevent: Add tevent tutorial files.
David Koňař [Wed, 12 Jun 2013 11:54:36 +0000 (12 13:54 +0200)]
tevent: Add tevent tutorial files.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
10 years agos3-libads: Print the debug string of a failed call with LDAP_OTHER.
Andreas Schneider [Wed, 12 Jun 2013 08:07:22 +0000 (12 10:07 +0200)]
s3-libads: Print the debug string of a failed call with LDAP_OTHER.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Jun 12 13:46:57 CEST 2013 on sn-devel-104

10 years agokrb5wrap: Move mask to the right position.
Andreas Schneider [Wed, 12 Jun 2013 08:08:44 +0000 (12 10:08 +0200)]
krb5wrap: Move mask to the right position.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agodsdb-tests ldap.py: Add test for usn behaviour on certain changes
Andrew Bartlett [Fri, 31 May 2013 04:14:54 +0000 (31 14:14 +1000)]
dsdb-tests ldap.py: Add test for usn behaviour on certain changes

This probes when the usn is updated, and when it is not.

Andrew Bartlett

Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Jun 12 11:54:01 CEST 2013 on sn-devel-104

10 years agodsdb-tests ldap.py: Fix quoting of print statements
Andrew Bartlett [Fri, 31 May 2013 01:15:51 +0000 (31 11:15 +1000)]
dsdb-tests ldap.py: Fix quoting of print statements

While python didn't mind (oddly) it really confused my editor.

Andrew Bartlett

Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agodsdb: Fix behaviour for when to update the USN when there is no change
Andrew Bartlett [Fri, 31 May 2013 04:16:02 +0000 (31 14:16 +1000)]
dsdb: Fix behaviour for when to update the USN when there is no change

This handles deletions and replacements with no value, or with an
exactly specified value, as well as modifies.

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agodsdb: Allow dsdb_find_dn_by_guid to show deleted DNs
Andrew Bartlett [Mon, 10 Jun 2013 02:22:40 +0000 (10 12:22 +1000)]
dsdb: Allow dsdb_find_dn_by_guid to show deleted DNs

This helps us in the KCC as we need to return the deleted DN for the GUID
in DsReplicaGetInfo calls (tested for deleted servers against Windows 2008R2).

Andrew Bartlett

Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agopython samba-tool drs: Correctly print KCC references to deleted servers
Andrew Bartlett [Mon, 10 Jun 2013 01:43:18 +0000 (10 11:43 +1000)]
python samba-tool drs: Correctly print KCC references to deleted servers

Tested against Windows 2008R2, presumably before the KCC ran.

Andrew Bartlett

Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agoFix bug #9932 - Currently the maximum number of aces in an SD is limited to 1000...
Partha Sarathi [Fri, 7 Jun 2013 23:30:07 +0000 (7 16:30 -0700)]
Fix bug #9932 - Currently the maximum number of aces in an SD is limited to 1000, but Microsoft supports around 1800.

Issue description: I was trying to add maximum number of aces on Microsoft
share, where I was able to add nearly 1800 aces on a file/folder SD. But Samba
does not support adding 1800 aces to SD instead it limited to 1000.

Expected behavior: Ideally SAMBA should also support as like Windows to compare
with Windows standard. Set to 2000 until we add EA limits in the server.

Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Jun 12 02:52:36 CEST 2013 on sn-devel-104

10 years agosmbd: Remove an unused variable
Volker Lendecke [Tue, 11 Jun 2013 19:07:26 +0000 (11 21:07 +0200)]
smbd: Remove an unused variable

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jun 12 01:00:44 CEST 2013 on sn-devel-104

10 years agolibrpc: Fix some "ignored asprint result" warnings
Volker Lendecke [Tue, 11 Jun 2013 18:53:05 +0000 (11 20:53 +0200)]
librpc: Fix some "ignored asprint result" warnings

While there, it removes some alloc/free calls

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agosmbd: Fix a const warning
Volker Lendecke [Tue, 11 Jun 2013 18:37:11 +0000 (11 20:37 +0200)]
smbd: Fix a const warning

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agosmbd: Fix a const warning
Volker Lendecke [Tue, 11 Jun 2013 18:35:55 +0000 (11 20:35 +0200)]
smbd: Fix a const warning

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agosmbd: Remove unused code
Volker Lendecke [Tue, 11 Jun 2013 18:34:00 +0000 (11 20:34 +0200)]
smbd: Remove unused code

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agolib: Remove an unused variable
Volker Lendecke [Tue, 11 Jun 2013 17:41:30 +0000 (11 19:41 +0200)]
lib: Remove an unused variable

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Jun 11 21:52:09 CEST 2013 on sn-devel-104

10 years agowinreg3: Fix a const warning
Volker Lendecke [Tue, 11 Jun 2013 17:27:17 +0000 (11 19:27 +0200)]
winreg3: Fix a const warning

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agolibsmb: add ABI/smbclient-0.2.1.sigs
David Disseldorp [Tue, 11 Jun 2013 12:20:53 +0000 (11 14:20 +0200)]
libsmb: add ABI/smbclient-0.2.1.sigs

Required following ABI vnum bump for smbc_get/setPort changes.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agoAdd smbc_getPort(), smbc_setPort(). Bump the .so minor number.
Jeremy Allison [Tue, 16 Apr 2013 21:53:09 +0000 (16 14:53 -0700)]
Add smbc_getPort(), smbc_setPort(). Bump the .so minor number.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
10 years agoPlumb the 'port' parameter into the connect code.
Jeremy Allison [Tue, 16 Apr 2013 21:13:57 +0000 (16 14:13 -0700)]
Plumb the 'port' parameter into the connect code.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
10 years agoAdd the port argument to SMBC_server().
Jeremy Allison [Tue, 16 Apr 2013 21:11:08 +0000 (16 14:11 -0700)]
Add the port argument to SMBC_server().

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
10 years agoAdd port argument to SMBC_attr_server(). Does nothing as yet.
Jeremy Allison [Tue, 16 Apr 2013 19:22:11 +0000 (16 12:22 -0700)]
Add port argument to SMBC_attr_server(). Does nothing as yet.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
10 years agoAdd the ability to parse out the port to SMBC_parse_path().
Jeremy Allison [Tue, 16 Apr 2013 19:09:41 +0000 (16 12:09 -0700)]
Add the ability to parse out the port to SMBC_parse_path().

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
10 years agoRemove remaining references to "password level" in the tree
Andrew Bartlett [Mon, 3 Jun 2013 00:38:29 +0000 (3 10:38 +1000)]
Remove remaining references to "password level" in the tree

Reviewed-by: Simo Sorce <idra@samba.org>
Autobuild-User(master): Simo Sorce <idra@samba.org>
Autobuild-Date(master): Tue Jun 11 16:25:54 CEST 2013 on sn-devel-104

10 years agodocs: Do not encourage unix passwords, and remove reference to password level
Andrew Bartlett [Mon, 3 Jun 2013 00:27:41 +0000 (3 10:27 +1000)]
docs: Do not encourage unix passwords, and remove reference to password level

Reviewed-by: Simo Sorce <idra@samba.org>
10 years agoauth: Remove "password level"
Andrew Bartlett [Mon, 3 Jun 2013 00:02:39 +0000 (3 10:02 +1000)]
auth: Remove "password level"

We now only lowercase the password, we do not attempt to find another case
combination that the password might be in.

This option is already depricated, so it is now time to remove it.

Andrew Bartlett

Reviewed-by: Simo Sorce <idra@samba.org>
10 years agodsdb: reset schema->{classes,attributes}_to_remove_size to 0
Stefan Metzmacher [Mon, 10 Jun 2013 08:46:41 +0000 (10 10:46 +0200)]
dsdb: reset schema->{classes,attributes}_to_remove_size to 0

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Jun 11 11:40:39 CEST 2013 on sn-devel-104

10 years agodsdb: use the correct talloc parent in dsdb_repl_merge_working_schema()
Stefan Metzmacher [Mon, 10 Jun 2013 08:45:25 +0000 (10 10:45 +0200)]
dsdb: use the correct talloc parent in dsdb_repl_merge_working_schema()

schema->{classes,attributes} are the DLIST pointer not an array.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agoRevert "s4-dsdb: Remove strcasecmp() fallback in replmd_ldb_message_element_attid_sort"
Andrew Bartlett [Wed, 5 Jun 2013 10:44:17 +0000 (5 20:44 +1000)]
Revert "s4-dsdb: Remove strcasecmp() fallback in replmd_ldb_message_element_attid_sort"

This reverts commit d799b25dd3ed0f72ee03949225ba241c5538d7d6.

Sometimes the schema just isn't right.  A segfault is not the correct
answer in those cases.

Andrew Bartlett

Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agos4-dfs_server: check for netbios aliases in ad_get_referrals
Björn Baumbach [Wed, 5 Jun 2013 13:01:14 +0000 (5 15:01 +0200)]
s4-dfs_server: check for netbios aliases in ad_get_referrals

Without this patch ad_get_referrals checks for netbios, dns names
and ip, but not for netbios aliases set by netbios aliases option,
whether the requested name is our dns name.

Pair-programmed-with: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Björn Baumbach <bb@sernet.de>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Tue Jun 11 01:12:08 CEST 2013 on sn-devel-104

10 years agoOptimization on POSIX platforms that have fstatat.
Jeremy Allison [Fri, 24 May 2013 17:33:38 +0000 (24 10:33 -0700)]
Optimization on POSIX platforms that have fstatat.

Tests show significant speedup in directory listings
by using fstatat instead of a full pathname walk.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Jun 10 20:14:12 CEST 2013 on sn-devel-104

10 years agoCheck for fstatat.
Jeremy Allison [Sat, 8 Jun 2013 00:53:45 +0000 (7 17:53 -0700)]
Check for fstatat.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
10 years agos4:samldb LDB module - MS-SAMR 3.1.1.8.10 "userAccountControl"
Matthias Dieter Wallnöfer [Sat, 8 Jun 2013 21:45:43 +0000 (8 23:45 +0200)]
s4:samldb LDB module - MS-SAMR 3.1.1.8.10 "userAccountControl"

"UF_LOCKOUT" and "UF_PASSWORD_EXPIRED" are never stored but rather are
used for special semantics.
"UF_LOCKOUT" performs an account lockout and "UF_PASSWORD_EXPIRED"
forces password expiration.

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Jun 10 07:32:35 CEST 2013 on sn-devel-104

10 years agos4:samr RPC server - dcesrv_samr_SetUserInfo() - password expiration
Matthias Dieter Wallnöfer [Sun, 9 Jun 2013 08:46:06 +0000 (9 10:46 +0200)]
s4:samr RPC server - dcesrv_samr_SetUserInfo() - password expiration

Also on level 26 this has to be handled the same as on levels 21, 23, 25.

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years ago.gitignore: Tidy up after removal of the autoconf build
Andrew Bartlett [Sat, 8 Jun 2013 08:10:36 +0000 (8 18:10 +1000)]
.gitignore: Tidy up after removal of the autoconf build

Reviewed-By: Jelmer Vernooij <jelmer@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Jun 10 04:42:46 CEST 2013 on sn-devel-104

10 years agotdb: Fix typos.
Ralph Wuerthner [Thu, 12 Jul 2012 09:18:46 +0000 (12 11:18 +0200)]
tdb: Fix typos.

Reviewed-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Jun  7 15:18:47 CEST 2013 on sn-devel-104

10 years agoAdd "repack" command to tdbtool documentation.
Ralph Wuerthner [Thu, 12 Jul 2012 09:08:04 +0000 (12 11:08 +0200)]
Add "repack" command to tdbtool documentation.

The original commit 'Add "repack" command to tdbtool.' only added
the documentation to docs-xml/manpages-3/tdbtool.8.xml and forgot
about lib/tdb/manpages/tdbtool.8.xml .

Reviewed-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
10 years agoRevert "dbwrap: dbwrap_fetch_locked_timeout()."
Volker Lendecke [Tue, 4 Jun 2013 10:29:32 +0000 (4 12:29 +0200)]
Revert "dbwrap: dbwrap_fetch_locked_timeout()."

This reverts commit f6eb187fdab6b8088bb065e418fe604c4eba7751.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Thu Jun  6 14:26:26 CEST 2013 on sn-devel-104

10 years agodocs: Fix a typo
Volker Lendecke [Tue, 4 Jun 2013 09:39:06 +0000 (4 11:39 +0200)]
docs: Fix a typo

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Karolin Seeger <kseeger@samba.org>
Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Thu Jun  6 11:47:22 CEST 2013 on sn-devel-104

10 years agosmbd: Change logging when SET_OFFLINE is not supported
Christof Schmitt [Thu, 6 Jun 2013 00:08:03 +0000 (5 17:08 -0700)]
smbd: Change logging when SET_OFFLINE is not supported

A client can send a request to set the OFFLINE attribute. In the default
code this is not supported and triggers a log message each time. Change
this to only log with level 0 when an actual errors occurs, and log
ENOTSUP with level 10.

Signed-off-by: Christof Schmitt <christof.schmitt@us.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Jun  6 04:30:26 CEST 2013 on sn-devel-104

10 years agos4:samldb LDB module - permit "userAccountControl" modifications without acct. type
Matthias Dieter Wallnöfer [Wed, 29 May 2013 20:17:35 +0000 (29 22:17 +0200)]
s4:samldb LDB module - permit "userAccountControl" modifications without acct. type

Obviously this defaults to UF_NORMAL_ACCOUNT. Some background can be found in
MS-SAMR section 3.1.1.8.10.

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Jun  5 03:26:25 CEST 2013 on sn-devel-104

10 years agos4:samldb LDB module - "userAccountControl" = 0 means UF_NORMAL_ACCOUNT on add
Matthias Dieter Wallnöfer [Sat, 21 Apr 2012 15:20:24 +0000 (21 17:20 +0200)]
s4:samldb LDB module - "userAccountControl" = 0 means UF_NORMAL_ACCOUNT on add

Windows Server 2008 has changed semantics in comparison to Server 2003.

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agos3:smbd: explain parameters in call to SMB_VFS_DURABLE_RECONNECT()
Michael Adam [Wed, 22 May 2013 18:16:50 +0000 (22 20:16 +0200)]
s3:smbd: explain parameters in call to SMB_VFS_DURABLE_RECONNECT()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Jun  4 21:58:16 CEST 2013 on sn-devel-104

10 years agos3:smbd: remove code duplication in smb2_create_send()
Michael Adam [Wed, 22 May 2013 17:53:12 +0000 (22 19:53 +0200)]
s3:smbd: remove code duplication in smb2_create_send()

Move the calls to smb2srv_open_recreate() from the parsing of
the create blobs (DHNC and DH2C) to a central place in the
open execution phase.
This is also where it should be called: in the durable reconnect
part, right before the call to SMB_VFS_DURABLE_RECONNECT()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agos3:smbd: remove old comment about scavenger timer from vfs_default_durable_reconnect()
Michael Adam [Wed, 22 May 2013 18:26:49 +0000 (22 20:26 +0200)]
s3:smbd: remove old comment about scavenger timer from vfs_default_durable_reconnect()

scavenger functionality belongs to the smb layer (and is meanwhile
implemented there).

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agotdb: change version to tdb-1.2.12
Stefan Metzmacher [Tue, 4 Jun 2013 08:48:20 +0000 (4 10:48 +0200)]
tdb: change version to tdb-1.2.12

* internal code cleanups
* crash fix for pytdb
* fix for 4GB overflow detection
  See http://permalink.gmane.org/gmane.network.samba.internals/42906 for
  an example of what happens.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Jun  4 16:07:55 CEST 2013 on sn-devel-104

10 years agosmbcquotas.c: fix a bug of -t
Peng Haitao [Mon, 27 May 2013 09:59:54 +0000 (27 17:59 +0800)]
smbcquotas.c: fix a bug of -t

'r' should be replaced with 't'.

Signed-off-by: Peng Haitao <penght@cn.fujitsu.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Tue Jun  4 13:06:52 CEST 2013 on sn-devel-104

10 years agos4:winbind: don't leak libnet_context into the main event context
Stefan Metzmacher [Fri, 31 May 2013 14:04:26 +0000 (31 16:04 +0200)]
s4:winbind: don't leak libnet_context into the main event context

This needs to be a talloc child of struct wbsrv_domain
otherwise the cleanup of a broken connection doesn't work.

The following command can trigger the leak on a domain controller.

root@dc:~/samba# ls -l /var/lib/samba/sysvol/samba.private/
total 16
drwxrwx---+ 5 root 3000000 4096 May 14 14:46 Policies
drwxrwx---+ 2 root 3000000 4096 May 14 11:45 scripts

gid 3000000 belongs to Builtin\Administrators.

The code triggers a ncacn_np: connection to the local smbd
and complains that domain BUILTIN is not available:

[2013/05/29 17:28:03,  2] ../source4/winbind/wb_init_domain.c:376(init_domain_recv_queryinfo)
  Expected domain name BUILTIN, DC dc.samba.private said SAMBA

In that case the connection was not closed, which is fixed by this commit.

Using ncalrpc: for all local SIDs and serving the BUILTIN domain is
a project for another day...

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Jun  4 11:05:09 CEST 2013 on sn-devel-104

10 years agos3:lib/ctdb_packet use sys_send in packet_fd_write
Christian Ambach [Mon, 3 Jun 2013 14:18:03 +0000 (3 16:18 +0200)]
s3:lib/ctdb_packet use sys_send in packet_fd_write

use the signal safe variant here to prevent spurious errors when running
with CTDB and a signal comes in

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Christian Ambach <ambi@samba.org>
Autobuild-Date(master): Mon Jun  3 20:01:22 CEST 2013 on sn-devel-104

10 years agoBug 8997: change libreplace GPL source to LGPL
David Disseldorp [Mon, 3 Jun 2013 11:00:31 +0000 (3 13:00 +0200)]
Bug 8997: change libreplace GPL source to LGPL

libreplace currently includes socket.c and getifaddrs.c both of which
are GPL licensed.
Although not required, talloc and tdb build alongside this source,
leading to some ambiguity regarding their LGPL licences.

The following copyright holders have agreed to the GPL->LGPL change:
lib/replace/getifaddrs.c
   Copyright (C) Andrew Tridgell 1998
   Copyright (C) Jeremy Allison 2007
   Copyright (C) Jelmer Vernooij <jelmer@samba.org> 2007

lib/replace/test/getifaddrs.c
lib/replace/socket.c
 * Copyright (C) Michael Adam <obnox@samba.org> 2008

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Jun  3 18:06:18 CEST 2013 on sn-devel-104

10 years agotorture: support printer publish pending responses
David Disseldorp [Wed, 29 May 2013 08:43:35 +0000 (29 10:43 +0200)]
torture: support printer publish pending responses

Windows (tested against 2k8r2) returns WERR_IO_PENDING and
DSPRINT_PENDING when a publish or unpublish is requested via
setprinter(level=7). Modify the AD printer publishing test to support
these responses.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Jun  3 16:06:15 CEST 2013 on sn-devel-104

10 years agotorture: add AD printer publishing test
David Disseldorp [Wed, 29 May 2013 08:43:34 +0000 (29 10:43 +0200)]
torture: add AD printer publishing test

This test publishes and unpublishes a printer using setprinter(level=7).
Printer info2.attributes and info7.action flags are check at each point
to ensure MS-RPRN conformance.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
10 years agoFix bug 9900: is_printer_published GUID retrieval
David Disseldorp [Wed, 29 May 2013 08:43:33 +0000 (29 10:43 +0200)]
Fix bug 9900: is_printer_published GUID retrieval

Samba currently always responds to GetPrinter(level = 7) requests with
DSPRINT_UNPUBLISH, regardless of the AD publish status tracked via the
PRINTER_ATTRIBUTE_PUBLISHED flag. This is due to erroneous "objectGUID"
unmarshalling in is_printer_published().

This change splits "objectGUID" retrieval into a separate function, and
adds a pull_reg_sz() call to correctly unmarshall the GUID.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
10 years agoprinting: explicitly clear PUBLISHED attribute
David Disseldorp [Wed, 29 May 2013 08:43:32 +0000 (29 10:43 +0200)]
printing: explicitly clear PUBLISHED attribute

Currently nt_printer_publish(DSPRINT_UNPUBLISH) flips (via xor) the
info2->attributes PRINTER_ATTRIBUTE_PUBLISHED flag, rather than
explicitly clearing it.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
10 years agotdb: Add another overflow check to tdb_expand_adjust
Volker Lendecke [Thu, 30 May 2013 14:23:17 +0000 (30 16:23 +0200)]
tdb: Add another overflow check to tdb_expand_adjust

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Mon Jun  3 14:08:54 CEST 2013 on sn-devel-104

10 years agotdb: Make tdb_recovery_allocate overflow-safe
Volker Lendecke [Thu, 30 May 2013 13:54:58 +0000 (30 15:54 +0200)]
tdb: Make tdb_recovery_allocate overflow-safe

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
10 years agotdb: Make tdb_recovery_size overflow-safe
Volker Lendecke [Thu, 30 May 2013 13:24:27 +0000 (30 15:24 +0200)]
tdb: Make tdb_recovery_size overflow-safe

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
10 years agotdb: add proper OOM/ENOSPC handling to tdb_expand()
Stefan Metzmacher [Tue, 28 May 2013 11:04:29 +0000 (28 13:04 +0200)]
tdb: add proper OOM/ENOSPC handling to tdb_expand()

Failing to do so will result in corrupt tdbs: We will overwrite
the hash chain pointers with 0x42424242.

Pair-Programmed-With: Volker Lendecke <vl@samba.org>

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
10 years agotdb: add overflow detection to tdb_expand_adjust()
Stefan Metzmacher [Tue, 28 May 2013 11:01:27 +0000 (28 13:01 +0200)]
tdb: add overflow detection to tdb_expand_adjust()

We round up at maximun to a new size of 4GB,
but still return at least the given size.

The caller has to deal with ENOSPC itself.

Pair-Programmed-With: Volker Lendecke <vl@samba.org>

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
10 years agotdb: add overflow/ENOSPC handling to tdb_expand_file()
Stefan Metzmacher [Tue, 28 May 2013 10:59:32 +0000 (28 12:59 +0200)]
tdb: add overflow/ENOSPC handling to tdb_expand_file()

Pair-Programmed-With: Volker Lendecke <vl@samba.org>

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
10 years agotdb: add a 'new_size' helper variable to tdb_expand_file()
Stefan Metzmacher [Tue, 28 May 2013 10:56:57 +0000 (28 12:56 +0200)]
tdb: add a 'new_size' helper variable to tdb_expand_file()

Pair-Programmed-With: Volker Lendecke <vl@samba.org>

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
10 years agotdb: Add overflow-checking tdb_add_off_t
Volker Lendecke [Thu, 30 May 2013 12:52:59 +0000 (30 14:52 +0200)]
tdb: Add overflow-checking tdb_add_off_t

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
10 years agoparam_table: Remove misleading allow dns updates options.
Michael Wood [Sat, 1 Jun 2013 08:37:37 +0000 (1 10:37 +0200)]
param_table: Remove misleading allow dns updates options.

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Jun  1 12:46:32 CEST 2013 on sn-devel-104

10 years agodocs: Avoid mentioning a possibly misleading option.
Michael Wood [Sat, 1 Jun 2013 08:35:56 +0000 (1 10:35 +0200)]
docs: Avoid mentioning a possibly misleading option.

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agoWHATSNEW: Fix 4.0 default for allow dns updates.
Michael Wood [Sat, 1 Jun 2013 08:34:20 +0000 (1 10:34 +0200)]
WHATSNEW: Fix 4.0 default for allow dns updates.

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agolibcli: Remove uneeded debug message
Kai Blin [Sat, 1 Jun 2013 08:24:12 +0000 (1 10:24 +0200)]
libcli: Remove uneeded debug message

Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agodns: Delete dnsNode objects when they are empty
Kai Blin [Sat, 1 Jun 2013 08:24:11 +0000 (1 10:24 +0200)]
dns: Delete dnsNode objects when they are empty

If an update leaves the dnsNode without any entries, the dnsNode object
should be deleted. Thanks to Günter Kukkukk for his excellent debugging
work on this one.

This should fix bug #9559

Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agos4-dns: set TTL value in the NS server part of the SOA record
Guenter Kukkukk [Thu, 30 May 2013 00:19:32 +0000 (30 02:19 +0200)]
s4-dns: set TTL value in the NS server part of the SOA record

noticed this when using samba-tool to create a new zone

Signed-off-by: Guenter Kukkukk <kukks@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu May 30 09:41:20 CEST 2013 on sn-devel-104

10 years agobuild-htmlman-nogit: Run build-htmlman-nogit with bash.
Karolin Seeger [Wed, 29 May 2013 08:25:25 +0000 (29 10:25 +0200)]
build-htmlman-nogit: Run build-htmlman-nogit with bash.

On debian/ubuntu, the "dash" which is sh, does not
provide pushd/popd...

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu May 30 04:48:06 CEST 2013 on sn-devel-104

10 years agobuild-htmlman-git: Run build-htmlman-git with bash.
Karolin Seeger [Wed, 29 May 2013 08:23:49 +0000 (29 10:23 +0200)]
build-htmlman-git: Run build-htmlman-git with bash.

    On debian/ubuntu, the "dash" which is sh, does not
    provide pushd/popd...

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agobuild-htmlman-nogit: manpages-3 has been moved to manpages.
Karolin Seeger [Wed, 29 May 2013 08:21:23 +0000 (29 10:21 +0200)]
build-htmlman-nogit: manpages-3 has been moved to manpages.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agobuild-htmlman-git: manpages-3 has been moved to manpages.
Karolin Seeger [Wed, 29 May 2013 08:20:39 +0000 (29 10:20 +0200)]
build-htmlman-git: manpages-3 has been moved to manpages.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agodocs-xml/.gitignore: manpages-3 has been moved to manpages.
Karolin Seeger [Wed, 29 May 2013 08:19:10 +0000 (29 10:19 +0200)]
docs-xml/.gitignore: manpages-3 has been moved to manpages.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agovfs_glusterfs: Samba VFS module for glusterfs
Anand Avati [Wed, 29 May 2013 11:21:46 +0000 (29 07:21 -0400)]
vfs_glusterfs: Samba VFS module for glusterfs

Implement a Samba VFS plugin for glusterfs based on gluster's gfapi.
This is a "bottom" vfs plugin (not something to be stacked on top of
another module), and translates (most) calls into closest actions
on gfapi.

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Simo Sorce <idra@samba.org>
Signed-off-by: Anand Avati <avati@redhat.com>
10 years agosamba-tool/dns: Set secure zone update flag after creating new zone
Amitay Isaacs [Mon, 27 May 2013 02:37:20 +0000 (27 12:37 +1000)]
samba-tool/dns: Set secure zone update flag after creating new zone

Windows DC ignores the secure update flag while creating new zone.  Windows
performs another operation to set the secure update flag.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
10 years agosamba-tool/dns: Pass on additional flags when creating zones
Amitay Isaacs [Mon, 27 May 2013 02:26:36 +0000 (27 12:26 +1000)]
samba-tool/dns: Pass on additional flags when creating zones

Windows DCs require additional flags to be set when creating zones.

This fixes bug #9599.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
10 years agos4-dns: Support update of SOA records
Amitay Isaacs [Thu, 6 Dec 2012 05:11:18 +0000 (6 16:11 +1100)]
s4-dns: Support update of SOA records

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
10 years agos4-rpc: dnsserver: When updating SOA record, use the specified serial
Amitay Isaacs [Thu, 6 Dec 2012 05:06:35 +0000 (6 16:06 +1100)]
s4-rpc: dnsserver: When updating SOA record, use the specified serial

This makes sure that when updating SOA record, the serial is set to the value
sent by client.  For all other records, serial is incremented.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
10 years agos4-rpc: dnsserver: dns_name_equal() returns boolean
Amitay Isaacs [Thu, 6 Dec 2012 05:05:26 +0000 (6 16:05 +1100)]
s4-rpc: dnsserver: dns_name_equal() returns boolean

Remove the remaining check for return value after strcmp() was changed to
dns_name_equal().

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agos4-rpc: dnsserver: Fix removal of trailing '.' in soa mname
Amitay Isaacs [Thu, 6 Dec 2012 05:04:32 +0000 (6 16:04 +1100)]
s4-rpc: dnsserver: Fix removal of trailing '.' in soa mname

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agobuild: Add missing new line to replaced python shebang line. (Fix bug #9909)
Michael Adam [Tue, 28 May 2013 10:19:34 +0000 (28 12:19 +0200)]
build: Add missing new line to replaced python shebang line. (Fix bug #9909)

When configuring with a non-standard python specified in
the PYTHON environment variable, the shebang lines in various
python tools like samba-tool and samba_dnsupdate get replaced.

This replace line for the shebang was missing a newline
which joined the shebang line with the following line,
rendereing those scripts with a nonempty second line unusuable,
for example samba_dnsupdate.

This patch fixes this bug which is bug #9909 on bugzilla.

Pair-Programmed-With: Karolin Seeger <kseeger@samba.org>

Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Wed May 29 13:21:51 CEST 2013 on sn-devel-104

10 years agos4-torture: Always compile backupkey ndr testsuite.
Günther Deschner [Mon, 27 May 2013 12:15:08 +0000 (27 14:15 +0200)]
s4-torture: Always compile backupkey ndr testsuite.

This removes another incorrect AD_DC_BUILD_IS_ENABLED check ifdef check. The ndr
test is not at all heimdal specific.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Alexander Bokovoy <ab@samba.org>
Autobuild-Date(master): Wed May 29 11:29:51 CEST 2013 on sn-devel-104

10 years agowaf: build PIEs if supported by the compiler
David Disseldorp [Tue, 28 May 2013 13:11:45 +0000 (28 15:11 +0200)]
waf: build PIEs if supported by the compiler

Currently waf performs a mandatory check for compiler PIE support,
unless --without-pie is specified.
This change makes Waf only perform the mandatory check if --with-pie is
specified. If neither --with-pie nor --without-pie are specified, then
PIEs are only built if compiler support is available.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
10 years agoautobuild: remove remnants of removed samba3 targets
Michael Adam [Tue, 28 May 2013 20:24:26 +0000 (28 22:24 +0200)]
autobuild: remove remnants of removed samba3 targets

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed May 29 09:35:16 CEST 2013 on sn-devel-104

10 years agonet: use smbconf_create_set_share() in "net conf import"
Michael Adam [Tue, 21 May 2013 14:50:49 +0000 (21 16:50 +0200)]
net: use smbconf_create_set_share() in "net conf import"

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Tue May 28 20:01:12 CEST 2013 on sn-devel-104