mount.cifs: don't leak passwords with verbose option
commitcead8716520ed395b997259e4c430aa05bf98001
authorJeff Layton <jlayton@redhat.com>
Fri, 25 Sep 2009 11:03:44 +0000 (25 07:03 -0400)
committerKarolin Seeger <kseeger@samba.org>
Thu, 1 Oct 2009 12:25:59 +0000 (1 14:25 +0200)
tree50181a2a49c1e092ba5860e2ddc0ff671a2e630e
parent3ea466e1b8e69d59736bf5b4452769014b17f0f3
mount.cifs: don't leak passwords with verbose option

When running mount.cifs with the --verbose option, it'll print out the
option string that it passes to the kernel...including the mount
password if there is one. Print a placeholder string instead to help
ensure that this info can't be used for nefarious purposes.

Also, the --verbose option printed the option string before it was
completely assembled anyway. This patch should also make sure that
the complete option string is printed out.

Finally, strndup passwords passed in on the command line to ensure that
they aren't shown by --verbose as well. Passwords used this way can
never be truly kept private from other users on the machine of course,
but it's simple enough to do it this way for completeness sake.

Reported-by: Ronald Volgers <r.c.volgers@student.utwente.nl>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Acked-by: Steve French <sfrench@us.ibm.com>
Part 2/2 of a fix for CVE-2009-2948.
(cherry picked from commit acfc9978afbde87dde3b70daccdbfd7e0a1d52e4)
source/client/mount.cifs.c