s4: libcli/finddcs_cldap: continue processing CLDAP until all addresses are used
commitc78585f5e2382097523693b564e49155bde85673
authorAlexander Bokovoy <ab@samba.org>
Wed, 20 May 2015 08:17:38 +0000 (20 11:17 +0300)
committerKarolin Seeger <kseeger@samba.org>
Thu, 21 May 2015 18:06:21 +0000 (21 20:06 +0200)
tree88a8556c2c214eee1907697f7fc251a56d3c7b0f
parentc7e44549a756f79a5267e22bd187bd94fa851e03
s4: libcli/finddcs_cldap: continue processing CLDAP until all addresses are used

This is a subtle bug that causes CLDAP pings to fail if SRV records
discovered cannot be resolved or connection to them cannot be
established. The code that fires up CLDAP ping will silently cancel
the whole tevent request without going to the next server in the queue.

This may happen, for example, when connection to IPv6 addresses couldn't
be established, or when IPv4 address is not online or blocked by
firewall.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11284

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit eb029b32e95c9e7382488f3a1b033cdbe3237c1c)

Autobuild-User(v4-2-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-2-test): Thu May 21 20:06:21 CEST 2015 on sn-devel-104
source4/libcli/finddcs_cldap.c