mount.cifs: don't leak passwords with verbose option
commitacfc9978afbde87dde3b70daccdbfd7e0a1d52e4
authorJeff Layton <jlayton@redhat.com>
Fri, 25 Sep 2009 11:03:44 +0000 (25 07:03 -0400)
committerKarolin Seeger <kseeger@samba.org>
Mon, 28 Sep 2009 11:51:28 +0000 (28 13:51 +0200)
treeb1e58bfb02253600da1b6f30ae31234e3d257b77
parentb656deb5d7e97176c32b61b7659258846db16887
mount.cifs: don't leak passwords with verbose option

When running mount.cifs with the --verbose option, it'll print out the
option string that it passes to the kernel...including the mount
password if there is one. Print a placeholder string instead to help
ensure that this info can't be used for nefarious purposes.

Also, the --verbose option printed the option string before it was
completely assembled anyway. This patch should also make sure that
the complete option string is printed out.

Finally, strndup passwords passed in on the command line to ensure that
they aren't shown by --verbose as well. Passwords used this way can
never be truly kept private from other users on the machine of course,
but it's simple enough to do it this way for completeness sake.

Reported-by: Ronald Volgers <r.c.volgers@student.utwente.nl>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Acked-by: Steve French <sfrench@us.ibm.com>
Part 2/2 of a fix for CVE-2009-2948.
source/client/mount.cifs.c