s4.2/fsmo.py: fixed fsmo transfer exception
commit1da224b43a534513b28e176d3b1926ffba06bcb4
authorSteve Howells <steve.howells@moscowfirst.com>
Sat, 31 Jan 2015 16:09:17 +0000 (31 16:09 +0000)
committerKarolin Seeger <kseeger@samba.org>
Tue, 9 Jun 2015 21:11:15 +0000 (9 23:11 +0200)
tree37d8ee68f686981637b7b615441c956dbfa3eb72
parent3e5744d1888d76a2becb8e512bc1be21d0000472
s4.2/fsmo.py: fixed fsmo transfer exception

In transfer_role() there is an duplicate call to samdb.modify() inside the if statement
where the type of role is being determined (specifically for the naming fsmo). This
call is unnecessary as after the if statement their is a correct call, with a try/catch
block, used by all fsmo transfers that will handle errors - such as the DC with the
fsmo role being offline.

The call to samdb.modify() inside the if statement for naming fsmo has been removed.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10924

Signed-off-by: Steve Howells <steve.howells@moscowfirst.com>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Marc Muehlfeld <mmuehlfeld@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 9198246f91c02e33ed7a3580588557d0fb9f8811)
python/samba/netcmd/fsmo.py