| commit | b489093e17c1d8e8619ba4c320f6cc051df4bac7 | |
| author | Julian Scheel <julian@jusst.de> | |
| Thu, 19 Oct 2017 09:22:58 +0000 (19 11:22 +0200) | ||
| committer | Jean-Baptiste Kempf <jb@videolan.org> | |
| Thu, 19 Oct 2017 09:34:55 +0000 (19 11:34 +0200) | ||
| tree | 3d0ca17b7c197e87f8b6040c5f1d7452a37de549 | treesnapshot (tar.gz zip) |
| parent | 284a8792b4945a5a6d83948caaf0b9dbd1a64418 | commitdiff |
mmal/codec: Remove useless locking
The mmal_queue is threadsafe and the block released from output callback
does not interfere with the block processing in decode. What could
happen was a use after free of block when checking the decode loop
condition after submitting the block to mmal. Avoid this by clearing the
block pointer before submitting to mmal and use it as extra loop
condition.
Signed-off-by: Julian Scheel <julian@jusst.de>
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
The mmal_queue is threadsafe and the block released from output callback
does not interfere with the block processing in decode. What could
happen was a use after free of block when checking the decode loop
condition after submitting the block to mmal. Avoid this by clearing the
block pointer before submitting to mmal and use it as extra loop
condition.
Signed-off-by: Julian Scheel <julian@jusst.de>
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
| modules/hw/mmal/codec.c | diffblobblamehistory |