From a2b0e4f14941199d75d55b650b6541d56807963e Mon Sep 17 00:00:00 2001 From: Toomas Soome Date: Sun, 16 Jul 2017 10:22:51 +0300 Subject: [PATCH] 9389 isnsd: this statement may fall through Reviewed by: Andy Fiddaman Reviewed by: Andrew Stormont Approved by: Hans Rosenfeld --- usr/src/cmd/isns/isnsd/dseng.c | 1 + usr/src/cmd/isns/isnsd/obj.c | 7 +++++++ usr/src/cmd/isns/isnsd/scn.c | 1 + usr/src/cmd/isns/isnsd/xml/data.c | 2 +- 4 files changed, 10 insertions(+), 1 deletion(-) diff --git a/usr/src/cmd/isns/isnsd/dseng.c b/usr/src/cmd/isns/isnsd/dseng.c index 558ce88c9e..0218679bb7 100644 --- a/usr/src/cmd/isns/isnsd/dseng.c +++ b/usr/src/cmd/isns/isnsd/dseng.c @@ -96,6 +96,7 @@ load_data( ISNS_ISCSI_SCN_BITMAP_ATTR_ID)]; scn_name = &obj->attrs[ATTR_INDEX_ISCSI( ISNS_ISCSI_NAME_ATTR_ID)]; + /* FALLTHROUGH */ case OBJ_PORTAL: if (puid != 0 && TYPE_OF_PARENT[obj->type] == ptype) { diff --git a/usr/src/cmd/isns/isnsd/obj.c b/usr/src/cmd/isns/isnsd/obj.c index b9004fb4f1..35bc44324a 100644 --- a/usr/src/cmd/isns/isnsd/obj.c +++ b/usr/src/cmd/isns/isnsd/obj.c @@ -1325,6 +1325,7 @@ assign_attr( return (1); } } + /* FALLTHROUGH */ case ISNS_PORTAL_NAME_ATTR_ID: case ISNS_ISCSI_NAME_ATTR_ID: case ISNS_ISCSI_ALIAS_ATTR_ID: @@ -1373,6 +1374,7 @@ assign_attr( if (attr->value.ui != 0) { break; } + /* FALLTHROUGH */ case ISNS_ENTITY_PROTOCOL_ATTR_ID: case ISNS_VERSION_RANGE_ATTR_ID: @@ -1485,11 +1487,13 @@ extract_attr( switch (tlv->attr_id) { case ISNS_EID_ATTR_ID: min_len = 0; + /* FALLTHROUGH */ case ISNS_PORTAL_NAME_ATTR_ID: case ISNS_ISCSI_ALIAS_ATTR_ID: case ISNS_DD_SET_NAME_ATTR_ID: case ISNS_DD_NAME_ATTR_ID: max_len = 256; + /* FALLTHROUGH */ case ISNS_ISCSI_NAME_ATTR_ID: case ISNS_PG_ISCSI_NAME_ATTR_ID: if (tlv->attr_len < min_len || tlv->attr_len > max_len) { @@ -1537,6 +1541,7 @@ extract_attr( ec = ISNS_RSP_MSG_FORMAT_ERROR; break; } + /* FALLTHROUGH */ case ISNS_PG_TAG_ATTR_ID: attr->tag = tlv->attr_id; attr->len = tlv->attr_len; @@ -1571,6 +1576,7 @@ extract_attr( } break; } + /* FALLTHROUGH */ case ISNS_ENTITY_INDEX_ATTR_ID: case ISNS_TIMESTAMP_ATTR_ID: default: @@ -2369,6 +2375,7 @@ reg_get_obj( case 4: pg_tag = ntohl(*(uint32_t *) &(*op)->attr_value[0]); + /* FALLTHROUGH */ case 0: pgt[2].value.ui = pg_tag; break; diff --git a/usr/src/cmd/isns/isnsd/scn.c b/usr/src/cmd/isns/isnsd/scn.c index 82027e4171..c3a934e2ea 100644 --- a/usr/src/cmd/isns/isnsd/scn.c +++ b/usr/src/cmd/isns/isnsd/scn.c @@ -2123,6 +2123,7 @@ scn_proc( if (scn_dispatched != 0) { (void) scn_trigger(); } + /* FALLTHROUGH */ case SCN_IGNORE: /* clean the scn(s) */ free_scn(); diff --git a/usr/src/cmd/isns/isnsd/xml/data.c b/usr/src/cmd/isns/isnsd/xml/data.c index 5887e81b45..3d5b17c762 100644 --- a/usr/src/cmd/isns/isnsd/xml/data.c +++ b/usr/src/cmd/isns/isnsd/xml/data.c @@ -410,7 +410,7 @@ convert_attr2xml( } else { node = child; } - /* LINTED E_CASE_FALLTHRU */ + /* FALLTHROUGH */ case 3: /* set content */ if (node) { xmlNodeSetContent(node, value); -- 2.11.4.GIT