From 4159a98a3536461402cc63f5784a0dd919e7d82c Mon Sep 17 00:00:00 2001 From: Toomas Soome Date: Sun, 16 Jul 2017 02:01:38 +0300 Subject: [PATCH] 9398 cron: this statement may fall through Reviewed by: Andy Fiddaman Reviewed by: Sebastian Wiedenroth Reviewed by: Andrew Stormont Approved by: Hans Rosenfeld --- usr/src/cmd/cron/at.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/usr/src/cmd/cron/at.c b/usr/src/cmd/cron/at.c index 128f041462..711f27d1a0 100644 --- a/usr/src/cmd/cron/at.c +++ b/usr/src/cmd/cron/at.c @@ -420,8 +420,7 @@ main(int argc, char **argv) static char * -mkjobname(t) -time_t t; +mkjobname(time_t t) { int i, fd; char *name; @@ -450,8 +449,7 @@ catch(int x) void -atabort(msg) -char *msg; +atabort(char *msg) { fprintf(stderr, "at: %s\n", gettext(msg)); @@ -515,8 +513,7 @@ leap(int year) * return time from time structure */ static time_t -gtime(tptr) -struct tm *tptr; +gtime(struct tm *tptr) { int i; long tv; @@ -737,9 +734,9 @@ out: fflush(NULL); } +/* remove jobs that are specified */ static int remove_jobs(int argc, char **argv, char *login) -/* remove jobs that are specified */ { int i, r; int error = 0; @@ -758,7 +755,7 @@ remove_jobs(int argc, char **argv, char *login) for (i = 0; i < argc; i++) if (strchr(argv[i], '/') != NULL) { fprintf(stderr, "at: %s: not a valid job-id\n", - argv[i]); + argv[i]); } else if (stat(argv[i], &buf)) { fprintf(stderr, "at: %s: ", argv[i]); perror(""); @@ -959,6 +956,7 @@ parse_time(char *t) case 12: /* CCYYMMDDhhmm */ century = atoi_for2(t); t += 2; + /* FALLTHROUGH */ case 10: /* YYMMDDhhmm */ tm.tm_year = atoi_for2(t); t += 2; @@ -967,6 +965,7 @@ parse_time(char *t) tm.tm_year += 100; } else tm.tm_year += (century - 19) * 100; + /* FALLTHROUGH */ case 8: /* MMDDhhmm */ tm.tm_mon = atoi_for2(t) - 1; t += 2; @@ -990,7 +989,8 @@ parse_time(char *t) } static int -atoi_for2(char *p) { +atoi_for2(char *p) +{ int value; value = (*p - '0') * 10 + *(p+1) - '0'; -- 2.11.4.GIT