From 5be1c8480cf0a22378c32d45c1764e43077a6b3e Mon Sep 17 00:00:00 2001 From: Yann Dirson Date: Sun, 20 Apr 2008 21:23:15 +0200 Subject: [PATCH] Move all() up to IVariantLoader. This may not be *required* for now, but all variant loaders must implement it anyway - even though we call it manually on each sublass. --- src/core/variantloader.h | 7 ++++++- src/variantfactories/kdepluginvariants.h | 6 +----- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/core/variantloader.h b/src/core/variantloader.h index c52c5b1..2f0eb59 100644 --- a/src/core/variantloader.h +++ b/src/core/variantloader.h @@ -18,7 +18,12 @@ class Repository; class TAGUA_EXPORT IVariantLoader { public: virtual ~IVariantLoader(); - + + /** + * \return a list of all non-hidden variants. + */ + virtual QStringList all() const = 0; + virtual Repository* getRepository(const QString& variant) = 0; }; diff --git a/src/variantfactories/kdepluginvariants.h b/src/variantfactories/kdepluginvariants.h index af7fd63..1a21d6a 100644 --- a/src/variantfactories/kdepluginvariants.h +++ b/src/variantfactories/kdepluginvariants.h @@ -28,11 +28,7 @@ class KDEPluginVariants : public IVariantLoader { Variant* create(const KService::Ptr& plugin); public: Variant* create(const QString& name); - - /** - * \return a list of all non-hidden variants. - */ - QStringList all() const; + virtual QStringList all() const; /** * \return the singleton IVariantLoader instance -- 2.11.4.GIT