From 33becfc886d60f0278b42c40646aa892ea4243fa Mon Sep 17 00:00:00 2001 From: Yann Dirson Date: Sun, 20 Apr 2008 21:11:54 +0200 Subject: [PATCH] Report error conditions instead of just doing nothing. --- src/core/board.cpp | 4 ++++ src/game.cpp | 5 ++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/core/board.cpp b/src/core/board.cpp index 28ca58e..64366da 100644 --- a/src/core/board.cpp +++ b/src/core/board.cpp @@ -11,6 +11,8 @@ #include "board.h" #include "piece.h" +#include + Board::Board(const Point& size) : m_size(size) { m_data.resize(m_size.x * m_size.y); @@ -48,6 +50,8 @@ void Board::set(const Point& p, const Piece& piece) { if (valid(p)) { m_data[p.x + p.y * m_size.x] = piece; } + else + kError() << "point is not valid" << p; } bool Board::valid(const Point& p) const { diff --git a/src/game.cpp b/src/game.cpp index 01f420a..5740801 100644 --- a/src/game.cpp +++ b/src/game.cpp @@ -820,7 +820,10 @@ void Game::load(const PGN& pgn) { // FIXME do not create a variant here if (var == pgn.m_tags.end()) { - vi = Variants::self().create("chess"); + if (!(vi = Variants::self().create("chess"))) { + kError() << "No such variant 'chess'"; + return; + } } else if (!(vi = Variants::self().create(var->second))) { kError() << "No such variant" << var->second; -- 2.11.4.GIT