From 890dfc4246c424ee8758bfebae36aa855134ec82 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Tue, 31 Jul 2012 15:36:15 +0300 Subject: [PATCH] checks: get rid of some delete_state() calls When we delete the state it's going to cause an unmatched state later and we're going to fill that with &undefined. May as well do it here instead. Signed-off-by: Dan Carpenter --- check_dev_queue_xmit.c | 2 +- check_unused_ret.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/check_dev_queue_xmit.c b/check_dev_queue_xmit.c index a746a7aa..d8c5d649 100644 --- a/check_dev_queue_xmit.c +++ b/check_dev_queue_xmit.c @@ -71,7 +71,7 @@ static void match_kfree_skb(const char *fn, struct expression *expr, void *param arg = get_argument_from_call_expr(expr->args, 0); if (!arg) return; - delete_state_expr(my_id, arg); + set_state_expr(my_id, arg, &undefined); } static void match_xmit(const char *fn, struct expression *expr, void *param) diff --git a/check_unused_ret.c b/check_unused_ret.c index 222a117e..00d54230 100644 --- a/check_unused_ret.c +++ b/check_unused_ret.c @@ -130,7 +130,7 @@ static void match_assign(struct expression *expr) left = strip_expr(expr->left); if (!left || left->type != EXPR_SYMBOL) return; - delete_state_expr(my_id, left); + set_state_expr(my_id, left, &undefined); } static void delete_used(int assign_id) @@ -165,7 +165,7 @@ static void match_symbol(struct expression *expr) if (!sm) return; delete_used_symbols(sm->possible); - delete_state_expr(my_id, expr); + set_state_expr(my_id, expr, &undefined); } static void match_end_func(struct symbol *sym) -- 2.11.4.GIT