From 4b194a17c76998aaf1a3aac37f780ae4d5d15e9e Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Fri, 15 Jan 2016 15:36:46 +0300 Subject: [PATCH] capped: fix return implies capped For some reason we were saying that if the value hadn't been modified then don't print it. But actually normally we don't modify values when we put a cap on them. Signed-off-by: Dan Carpenter --- smatch_capped.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/smatch_capped.c b/smatch_capped.c index aaf79399..84914e57 100644 --- a/smatch_capped.c +++ b/smatch_capped.c @@ -198,17 +198,6 @@ static void struct_member_callback(struct expression *call, int param, char *pri sql_insert_caller_info(call, CAPPED_DATA, param, printed_name, "1"); } -static int is_unmodified(const char *name) -{ - char orig[256]; - - snprintf(orig, sizeof(orig), "%s orig", name); - - if (get_comparison_strings(name, orig) == SPECIAL_EQUAL) - return 1; - return 0; -} - static void print_return_implies_capped(int return_id, char *return_ranges, struct expression *expr) { struct smatch_state *orig, *estate; @@ -233,9 +222,6 @@ static void print_return_implies_capped(int return_id, char *return_ranges, stru if (orig == &capped) continue; - if (!is_unmodified(sm->name)) - continue; - param_name = get_param_name(sm); if (!param_name) continue; -- 2.11.4.GIT