From 29fea2de3a0cbae65bc8b7de2b8d8e9acbaddd97 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Fri, 9 Jan 2015 12:45:06 +0300 Subject: [PATCH] hooks: allocating 1 too much There are a couple off by one bugs here, which waste a few bytes of RAM. Signed-off-by: Dan Carpenter --- smatch_hooks.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/smatch_hooks.c b/smatch_hooks.c index ea88112b..e5c54922 100644 --- a/smatch_hooks.c +++ b/smatch_hooks.c @@ -303,7 +303,7 @@ struct smatch_state *__client_unmatched_state_function(struct sm_state *sm) void call_pre_merge_hook(struct sm_state *sm) { - if (sm->owner > num_checks) + if (sm->owner >= num_checks) return; if (pre_merge_hooks[sm->owner]) @@ -361,7 +361,7 @@ void __call_scope_hooks(void) void allocate_hook_memory(void) { - pre_merge_hooks = malloc((num_checks + 1) * sizeof(*pre_merge_hooks)); - memset(pre_merge_hooks, 0, (num_checks + 1) * sizeof(*pre_merge_hooks)); + pre_merge_hooks = malloc(num_checks * sizeof(*pre_merge_hooks)); + memset(pre_merge_hooks, 0, num_checks * sizeof(*pre_merge_hooks)); } -- 2.11.4.GIT