| commit | 8a14f53700f8a1d74eb2debd8bcd8ebd20fed12d | |
| author | Dan Carpenter <dan.carpenter@oracle.com> | |
| Thu, 14 Mar 2013 11:13:19 +0000 (14 14:13 +0300) | ||
| committer | Dan Carpenter <dan.carpenter@oracle.com> | |
| Thu, 14 Mar 2013 11:13:19 +0000 (14 14:13 +0300) | ||
| tree | c6266e56153f335c647a3f363859eb2f046695fe | treesnapshot (tar.gz zip) |
| parent | 6a1c87ff4845d4b9de91ddaebe11f1127903a310 | commitdiff |
conditions: fix small signedness bug in compares
If I recall correctly, we always get signed comparisons here and manually
change them to SPECIAL_UNSIGNED_ as needed. In comparisons the type is
promoted to whichever side has more positive bits. So a comparison between
and int and a unsigned char is signed. In the original code it would have
been treated as unsigned.
I've updated check_signed.c to match.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
If I recall correctly, we always get signed comparisons here and manually
change them to SPECIAL_UNSIGNED_ as needed. In comparisons the type is
promoted to whichever side has more positive bits. So a comparison between
and int and a unsigned char is signed. In the original code it would have
been treated as unsigned.
I've updated check_signed.c to match.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
| check_signed.c | diffblobblamehistory | |
| smatch_conditions.c | diffblobblamehistory |