If a value is assigned but never used it is an expensive
commita1aa42ab15aff354c7fa3c411f8e44e73406b168
authorDavid Greaves <david@dgreaves.com>
Fri, 13 Mar 2009 20:32:47 +0000 (13 20:32 +0000)
committerDavid Greaves <david@dgreaves.com>
Fri, 13 Mar 2009 20:32:47 +0000 (13 20:32 +0000)
treec7f0973f73e6c0e34c48408aaf1fa7f1e5fe5653
parent7bdc6405039b5757ec1e6c482d19b3877b280d59
If a value is assigned but never used it is an expensive
memory operation that is never used. These changes remove
those assignments.

Note the dynamic_cast instead of the static_cast. Since
the cast is an up cast to the derived class, a dynamic_cast
is more appropriate. But since dynamic_cast can return zero
a pointer check is put in as well.

Signed-off-by: Erik Hovland <erik@hovland.org>
src/ui/CategoryDialog.cc
src/ui/PreferencesDialog.cc